Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update for missing static ip address #3831

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aavdberg
Copy link

@aavdberg aavdberg commented Nov 22, 2024

Description

This pull request includes several changes to the avm/res/container-instance/container-group/main.bicep file to support the optional assignment of a static IP address to a container group when the IP address type is set to 'Private'. The most important changes are summarized below:

Enhancements to IP address configuration:

  • Added a new parameter staticIpAddress to optionally specify a static IP address for the container group.
  • Modified the ipAddress property in the containergroup resource to conditionally include the staticIpAddress if the ipAddressType is 'Private'.
  • Added an output staticIpAddress to expose the static IP address of the container group.
  • Introduced a new type staticIpAddressType to describe the static IP address configuration.

Pipeline Reference

Pipeline
avm.res.container-instance.container-group

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@aavdberg aavdberg requested review from a team as code owners November 22, 2024 13:34

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Nov 22, 2024
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Nov 22, 2024

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@aavdberg aavdberg changed the title Update main.bicep Update for missing static ip address Nov 22, 2024
@aavdberg aavdberg changed the title Update for missing static ip address Feat: Update for missing static ip address Nov 22, 2024
@aavdberg aavdberg changed the title Feat: Update for missing static ip address feat: Update for missing static ip address Nov 22, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that you have to run the Set-AVMModule utility to regenerate the ARM JSON & Readme file following the change (as per the contribution guide)

@@ -29,6 +29,9 @@ param restartPolicy string = 'Always'
])
param ipAddressType string = 'Public'

@description('Optional. The static IP address for the container group.')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@description('Optional. The static IP address for the container group.')
@description('Optional. The static IP address for the container group. Only applied if \'ipAddressType\' is \'private\'.')

@@ -384,6 +393,11 @@ type ipAddressPortsType = {
protocol: string
}[]

type staticIpAddressType = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this type can be removed as not used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Module Owner 📣 This module needs an owner to develop or maintain it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants