-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update for missing static ip address #3831
base: main
Are you sure you want to change the base?
Conversation
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. |
Important If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs). To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label! The core team will only review and approve PRs that have this label applied! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that you have to run the Set-AVMModule
utility to regenerate the ARM JSON & Readme file following the change (as per the contribution guide)
@@ -29,6 +29,9 @@ param restartPolicy string = 'Always' | |||
]) | |||
param ipAddressType string = 'Public' | |||
|
|||
@description('Optional. The static IP address for the container group.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@description('Optional. The static IP address for the container group.') | |
@description('Optional. The static IP address for the container group. Only applied if \'ipAddressType\' is \'private\'.') |
@@ -384,6 +393,11 @@ type ipAddressPortsType = { | |||
protocol: string | |||
}[] | |||
|
|||
type staticIpAddressType = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this type can be removed as not used?
Description
This pull request includes several changes to the
avm/res/container-instance/container-group/main.bicep
file to support the optional assignment of a static IP address to a container group when the IP address type is set to 'Private'. The most important changes are summarized below:Enhancements to IP address configuration:
staticIpAddress
to optionally specify a static IP address for the container group.ipAddress
property in thecontainergroup
resource to conditionally include thestaticIpAddress
if theipAddressType
is 'Private'.staticIpAddress
to expose the static IP address of the container group.staticIpAddressType
to describe the static IP address configuration.Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.