-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add enableAad
parameter to conditionally configure AAD profile in Kubernetes
#3828
Open
Menghua1
wants to merge
18
commits into
Azure:main
Choose a base branch
from
Menghua1:fix/add-aad-profile-conditional
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+87
−24
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
0941723
add .yml
Menghua1 b893575
Merge branch 'Azure:main' into main
Menghua1 9c3dc76
Merge branch 'Azure:main' into main
Menghua1 27dc229
add avm.ptn.azd.ml-project.yml
Menghua1 7a4db43
Merge branch 'Azure:main' into main
Menghua1 818d862
add ml-ai-environment yml
Menghua1 42c1674
Merge branch 'Azure:main' into main
Menghua1 cfddbc2
Merge branch 'Azure:main' into main
Menghua1 757118a
Merge branch 'Azure:main' into main
Menghua1 1e7a26a
Merge branch 'Azure:main' into main
Menghua1 f51ee59
Merge branch 'Azure:main' into main
Menghua1 6ffd725
Merge branch 'Azure:main' into main
Menghua1 be96ada
Merge branch 'Azure:main' into main
Menghua1 4f34881
Merge branch 'Azure:main' into main
Menghua1 09a0caa
Merge branch 'Azure:main' into main
Menghua1 b462fa9
Merge branch 'Azure:main' into main
Menghua1 3de5818
Add conditional judgment for aadProfile parameters
Menghua1 71933fd
update test parameter
Menghua1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,6 +50,7 @@ module testDeployment '../../../main.bicep' = [ | |
mode: 'System' | ||
} | ||
] | ||
enableAad: true | ||
} | ||
} | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there are any required parameters, would it not maybe be simpler to change this condition do something like
aadProfile: !empty(aadProfileClientAppID) ? {
?Mind you, I have no clue if any of those parameter is required, so this is just an example.
An alternative, by the way, would be to add a user defined type for the
aadProfile
that is used by a corresponding parameter:param aadProfile aadProfileType?
and would contain all the below properties. If implemented, the above suggested check could be changed to something likeaadProfile: !empty(aadProfile) ? {
Just some ideas 😏