feat: avm/res/compute/gallery: Added UDT applicationsType

[johnlokerse]

Description

This PR adds the applicationsType UDT and updates existing UDTs to follow AVM standards.

Tagging owner: @ReneHezser

Pipeline Reference

Pipeline

Type of Change

• Update to CI Environment or utilities (Non-module affecting changes)
• Azure Verified Module updates:
  • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
    • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
    • The bug was found by the module author, and no one has opened an issue to report it yet.
  • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
  • Breaking changes and I have bumped the MAJOR version in version.json.
  • Update to documentation

Checklist

• I'm sure there are no other open Pull Requests for the same update/change
• I have run Set-AVMModule locally to generate the supporting module files.
• My corresponding pipelines / checks run clean and green without any errors or warnings

[microsoft-github-policy-service]

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

[microsoft-github-policy-service]

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

[ReneHezser]

Thank you for your contribution. I added some small comments.

[ReneHezser]

While this is a valid place to import external UDTs, we agreed to import them at the location where they are used. This way it is clear where they come from.
I'd put the import roleAssignmentType right before the param roleAssignments.
This applies to all imports and references of imported types (AVM common or your own).

[johnlokerse]

💡 Thanks for the feedback! Is the single line import required for this type as well?
import { identifierType, purchasePlanType, resourceRangeType } from './image/main.bicep'

Or is this fine as it is?

[johnlokerse]

Nevermind, these are used within a UDT so must be in the one-liner :)

[AlexanderSehr]

One point may have gotten lost a bit.

Hey @johnlokerse, long time no see. 😄 To build on top of what @ReneHezser said: Just for the types that you import from other templates, please import them on top of where they are used. For example:

import { lockType } from 'br/public:avm/utl/types/avm-common-types:0.3.0'
@sys.description('Optional. The lock settings of the service.')
param lock lockType?

[AlexanderSehr]

Just makes it a bit easier to find - especially if the module would happen to not have any other types :) (in know that's not the case for you, but I wanted to mention it)

[johnlokerse]

Done! Also, I have moved the imports at the UDTs to above the @export():

[johnlokerse]

Thank you for your contribution. I added some small comments.

Thanks! Implemented the comments. Could you re-check it to see if it's as expected?

[ReneHezser]

Thanks again for your contribution.

For next time, please do not solve conversations. Usually, the reviewer does that after checking again. This makes it easier for us to do the reviews on many modules at the same time.