Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avm/res/storage-account - skip azureFilesIdentityBasedAuthentication when empty instead of null #3808

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AVDGuy
Copy link

@AVDGuy AVDGuy commented Nov 19, 2024

When deploying this template for an existing storage account, it removes the azureFilesIdentityBasedAuthentication method when azureFilesIdentityBasedAuthentication is empty. In case of AD join, where you would use the powershell module to join the storage account, the storage acocunt loses authentication method for the share.

With this fix it skips the property all together when empty.

Description

Pipeline Reference

Pipeline

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

…tion when empty instead of null

When deploying this template for an existing storage account, it removes the azureFilesIdentityBasedAuthentication method when azureFilesIdentityBasedAuthentication is empty. In case of AD join, where you would use the powershell module to join the storage account, the storage acocunt loses authentication method for the share.

With this fix it skips the property all together when empty.
@AVDGuy AVDGuy requested review from a team as code owners November 19, 2024 16:17
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Nov 19, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Nov 19, 2024

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Nov 19, 2024
@AlexanderSehr AlexanderSehr changed the title fix: avm/res/storage-account - skip azureFilesIdentityBasedAuthentica… fix: avm/res/storage-account - skip azureFilesIdentityBasedAuthentication when empty instead of null Nov 24, 2024
@AlexanderSehr
Copy link
Contributor

Hey @AVDGuy,
good suggestion and nice account name 😄
As per the contribution flow, there'd be a few open asks such as

  • Running the Set-AVMModule utility on the module to regenerate files such as the template & readme
  • Attaching a pipeline badge from a successful run
    Ultimately, it will then be @ktremain / @fblix who will review & approve the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Module Owner 📣 This module needs an owner to develop or maintain it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants