-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add UDT for all avm/res/sql/server
submodules
#3807
base: main
Are you sure you want to change the base?
Conversation
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. |
Important If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs). To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label! The core team will only review and approve PRs that have this label applied! |
avm.res.sql.server
submodulesavm.res.sql.server
submodules
avm.res.sql.server
submodulesavm/res/sql/server
submodules
@@ -557,6 +555,7 @@ output privateEndpoints array = [ | |||
import { diagnosticSettingFullType } from 'br/public:avm/utl/types/avm-common-types:0.2.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a recommendation as per the other type imports from the avm-common-types, please move this import on top of the parameter where it is used. Makes it a bit easier to understand where the type is coming from.
The reamining types are fine were they are. Would just be nice to have the consistency for the common types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not used at a parameter, but as a type within the databasePropertyType
. You cannot move a type import inside a type declaration AFAIK. What would be your suggestion for that?
Description
This PR adds the remaining UDTs for al SQL submodules
Pipeline Reference
Pls note that WAF fails due to missing maintenance window in my subscription.
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.