Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add UDT for all avm/res/sql/server submodules #3807

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

peterbud
Copy link
Contributor

@peterbud peterbud commented Nov 18, 2024

Description

This PR adds the remaining UDTs for al SQL submodules

Pipeline Reference

Pipeline
avm.res.sql.server

Pls note that WAF fails due to missing maintenance window in my subscription.

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@peterbud peterbud requested review from a team as code owners November 18, 2024 12:46
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Nov 18, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Nov 18, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Nov 18, 2024

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@peterbud peterbud changed the title Add UDT for all avm.res.sql.server submodules feat: Add UDT for all avm.res.sql.server submodules Nov 18, 2024
@peterbud peterbud changed the title feat: Add UDT for all avm.res.sql.server submodules feat: Add UDT for all avm/res/sql/server submodules Nov 18, 2024
@peterbud peterbud removed the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Nov 18, 2024
@peterbud peterbud requested a review from krbar November 20, 2024 13:27
@@ -557,6 +555,7 @@ output privateEndpoints array = [
import { diagnosticSettingFullType } from 'br/public:avm/utl/types/avm-common-types:0.2.1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a recommendation as per the other type imports from the avm-common-types, please move this import on top of the parameter where it is used. Makes it a bit easier to understand where the type is coming from.
The reamining types are fine were they are. Would just be nice to have the consistency for the common types.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not used at a parameter, but as a type within the databasePropertyType. You cannot move a type import inside a type declaration AFAIK. What would be your suggestion for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants