feat: New module Issue1314 P2S VPN Gateway resource #3780
Conversation
This commit adds the p2s-vpn-gateway module to the network resources in the avm/res/network directory. The module allows for the deployment of a Virtual Hub P2S Gateway. It includes the necessary Bicep files, tests, and dependencies.
…heffler/bicep-registry-modules into Issue1314-p2s-vpn-gateway
…ble' in P2S VPN Gateway module and tests
avm-team-linter
bot
added
the
Needs: Core Team 🧞
microsoft-github-policy-service
bot
added
the
Needs: Triage 🔍
|
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. |
microsoft-github-policy-service
bot
added
the
Type: AVM 🅰️ ✌️ Ⓜ️
|
Important If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs). To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label! The core team will only review and approve PRs that have this label applied! |
|
Hey @ericscheffler , Firstly, thanks for your work on this PR! We have made some changes to the AVM CI, detailed below, which means we need you to update your fork to pull in these latest changes and re-run your tests to show they still are passing prior to approving and merging this PR, as we don't and it fails once merged the publishing of your module will fail and will be blocked going forward until the test pass again via additional PRs. Changes to CI That Have Been Made That You Need To Take Action On
Any questions reach out to the AVM Core Team by tagging us in your PR here or internally via Teams Thanks Jack (AVM Core Team) |
|
Converted to draft, troubleshooting new issues with WAF test following recent CI/CD changes |
|
Updated & tests succeeding, marking as Ready for review |
eriqua
changed the title
| param vpnClientAddressPoolAddressPrefixes array = [] | ||
|
|
||
| @description('Required. The resource ID of the gateways virtual hub.') | ||
| param virtualHubId string |
There was a problem hiding this comment.
| param virtualHubId string | |
| param virtualHubResourceId string |
As per ref
| param vpnGatewayScaleUnit int? | ||
|
|
||
| @description('Required. The resource ID of the VPN Server Configuration.') | ||
| param vpnServerConfigurationId string |
There was a problem hiding this comment.
| param vpnServerConfigurationId string | |
| param vpnServerConfigurationResourceId string |
As per ref
| } | ||
| ] | ||
| staticRoutesConfig: { | ||
| @description('Optional. ') |
There was a problem hiding this comment.
There seems something to be missing 😄
| nextHopIpAddress: string? | ||
| } | ||
| ] | ||
| staticRoutesConfig: { |
| }? | ||
|
|
||
| type vnetRoutesStaticRoutesType = { | ||
| staticRoutes: [ |
| kind: ('CanNotDelete' | 'ReadOnly' | 'None')? | ||
| }? | ||
|
|
||
| type vnetRoutesStaticRoutesType = { |
There was a problem hiding this comment.
| type vnetRoutesStaticRoutesType = { | |
| @export() | |
| @description('A type to describe a static route for a vnet route') | |
| type vnetRoutesStaticRoutesType = { |
| kind: ('CanNotDelete' | 'ReadOnly' | 'None')? | ||
| }? | ||
|
|
||
| type vnetRoutesStaticRoutesType = { |
There was a problem hiding this comment.
This is not used. Should be type be removed?
| param outboundRouteMapResourceId string? | ||
|
|
||
| @description('Optional. The Labels to propagate routes to.') | ||
| param propagatedLabelNames array = [] |
There was a problem hiding this comment.
| param propagatedLabelNames array = [] | |
| param propagatedLabelNames string[] = [] |
| param associatedRouteTableName string? | ||
|
|
||
| @description('Optional. The names of the route tables to propagate to the P2S VPN Gateway.') | ||
| param propagatedRouteTableNames array = [] |
There was a problem hiding this comment.
| param propagatedRouteTableNames array = [] | |
| param propagatedRouteTableNames string[] = [] |
| metadata name = 'Using only defaults' | ||
| metadata description = 'This instance deploys the module with the minimum set of required parameters.' |
There was a problem hiding this comment.
Incorrect description. I guess you meant
| metadata name = 'Using only defaults' | |
| metadata description = 'This instance deploys the module with the minimum set of required parameters.' | |
| metadata name = 'Using large parameter set' | |
| metadata description = 'This instance deploys the module with most of its features enabled.' |
| lock: { | ||
| kind: 'CanNotDelete' | ||
| name: 'myCustomLockName' | ||
| } |
There was a problem hiding this comment.
| lock: { | |
| kind: 'CanNotDelete' | |
| name: 'myCustomLockName' | |
| } |
Not needed for WAF-alignment
Description
This PR contains a new AVM resource for the Microsoft.Network/p2svpnGateways resource provider, which builds a P2S VPN Gateway within a VWAN Virtual Hub. This resource requires a Virtual WAN and Virtual Hub, as well as a VPN Server Configuration to deploy successfully.
Closes #1314
Pipeline Reference
Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.