Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug around routing intent #55

Merged
merged 9 commits into from
Oct 11, 2023
Merged

Fix bug around routing intent #55

merged 9 commits into from
Oct 11, 2023

Conversation

MilesCameron-DMs
Copy link
Contributor

@MilesCameron-DMs MilesCameron-DMs commented Oct 10, 2023 •
edited
Loading

Overview/Summary

Please see #54

This PR fixes/adds/changes/removes

  1. Passes an object over for routing config when it should be null

Breaking Changes

None

Testing Evidence

I have tested this with routing intent enabled in our test and production environment.

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (LZ-Vending Core Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated one or more of the following tests (if required)
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)

@MilesCameron-DMs MilesCameron-DMs requested a review from a team as a code owner October 10, 2023 18:15
jtracey93
jtracey93 requested changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typos

main.bicep Outdated Show resolved Hide resolved
main.bicep.parameters.md Outdated Show resolved Hide resolved
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback Awaiting feedback from the issue/PR author label Oct 10, 2023
MilesCameron-DMs
MilesCameron-DMs commented Oct 11, 2023
View reviewed changes
Copy link
Contributor Author

@MilesCameron-DMs MilesCameron-DMs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @jtracey93

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback Awaiting feedback from the issue/PR author label Oct 11, 2023
@jtracey93
Copy link
Collaborator

Tests are failing due to #56, will resolve in a later PR

jtracey93
jtracey93 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 linked an issue Oct 11, 2023 that may be closed by this pull request
🪲 Bug Report - Code does not work with vWAN routing intent enabled #54
Closed
@jtracey93 jtracey93 merged commit a842f98 into Azure:main Oct 11, 2023
4 of 6 checks passed
@jtracey93
Copy link
Collaborator

FYI @MilesCameron-DMs we will need to cut a release on the upstream Bicep Public Registry, so this wont be available instantly on the registry 👍

@MilesCameron-DMs
Copy link
Contributor Author

No problem - thanks @jtracey93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtracey93 jtracey93 jtracey93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🪲 Bug Report - Code does not work with vWAN routing intent enabled
2 participants
@MilesCameron-DMs @jtracey93