Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update batch endpoint cli and sdk notebook examples to use newer images #3001

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Update batch endpoint cli and sdk notebook examples to use newer images #3001

merged 2 commits into from
Feb 13, 2024

Conversation

yetamsft
Copy link
Member

@yetamsft yetamsft commented Feb 13, 2024 •
edited
Loading

Description

The previous image used in batch endpoint examples is out of its EOL date and deprecated. Replace them by the newer image to recover the tests.
 

Checklist

  • I have read the contribution guidelines.
  • I have coordinated with the docs team ([email protected]) if this PR deletes files or changes any file names or file extensions.
  • Pull request includes test coverage for the included changes.
  • This notebook or file is added to the CODEOWNERS file, pointing to the author or the author's team.

@yetamsft yetamsft changed the title Fix imagenet classifier notebook Update batch endpoint cli and sdk notebook examples to use newer image Feb 13, 2024
@yetamsft yetamsft changed the title Update batch endpoint cli and sdk notebook examples to use newer image Update batch endpoint cli and sdk notebook examples to use newer images Feb 13, 2024
lgayhardt
lgayhardt approved these changes Feb 13, 2024
View reviewed changes
Copy link

@lgayhardt lgayhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs approval. This change will not break our build.

@yetamsft yetamsft merged commit 9815ee2 into main Feb 13, 2024
16 checks passed
@yetamsft yetamsft deleted the yeta/fix_imagenet_notebook branch February 13, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgayhardt lgayhardt lgayhardt approved these changes

@chupadhy chupadhy chupadhy approved these changes

@sdgilley sdgilley Awaiting requested review from sdgilley sdgilley is a code owner

@msakande msakande Awaiting requested review from msakande msakande is a code owner

@Blackmist Blackmist Awaiting requested review from Blackmist Blackmist is a code owner

@ssalgadodev ssalgadodev Awaiting requested review from ssalgadodev ssalgadodev is a code owner

@fbsolo-ms1 fbsolo-ms1 Awaiting requested review from fbsolo-ms1 fbsolo-ms1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yetamsft @lgayhardt @chupadhy