Moved otel support for polling into poller #3279
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed custom code from
create_certificateAPI code and moved the corresponding logic into thePoller.This involved adding an additional parameter to the
callbackforPoller::with_callbackthat provides thectxused for the pipeline.Bonus: Instead of using a tuple to maintain the state of the "stream" created by the
Poller, encapsulate the state in a structure to make it easier to modify the state of the "stream" moving forward (when there were 3 fields in the state, it wasn't a huge deal, but with 5 fields, it was getting unwieldy).NOTE: This is still a draft PR, the next step is to work on similar changes for pagers.