-
Notifications
You must be signed in to change notification settings - Fork 313
Initial performance test infrastructure #3110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial performance test infrastructure #3110
Conversation
…e performance tests
2398a68
to
90fb660
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces initial performance test infrastructure for the Rust SDK, providing mechanisms to measure SDK client operation performance and defining performance tests for KeyVault secrets and Storage blob operations that match existing C++ SDK tests.
- Adds core performance testing framework with
PerfRunner
andPerfTest
trait - Implements performance tests for KeyVault
get_secret
and Storagelist_blobs
operations - Creates supporting pipeline configuration files for automated performance testing
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
sdk/core/azure_core_test/src/perf/mod.rs | Core performance testing framework with runner, test traits, and configuration |
sdk/core/azure_core_test/src/perf/framework_tests.rs | Unit tests for the performance test framework |
sdk/core/azure_core_test/src/perf/config_tests.rs | Configuration parsing and validation tests |
sdk/keyvault/azure_security_keyvault_secrets/perf/get_secret.rs | KeyVault get_secret performance test implementation |
sdk/storage/azure_storage_blob/perf/list_blob_test.rs | Storage list_blobs performance test implementation |
sdk/storage/azure_storage_blob/perf/perf_tests.rs | Storage performance test runner entry point |
sdk/core/azure_core_test/src/recording.rs | Updated to use OnceLock instead of deprecated OnceCell |
Various Cargo.toml files | Added performance test configurations and dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A great start! Mostly just nits and nothing I'd say is blocking, but could use a little polish before we call it a wrap (for now).
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 nits, but you could merge and get those in the next PR if you want to get this in. Looks great!
This PR adds the start of performance test infrastructure for the Rust SDK.
This support is not complete, but it does provide a mechanism to measure the performance of SDK client operations.
It also defines a performance test for the KeyVault get_secrets API and the Storage Blobs list_blobs API which match the tests which exist for the C++ SDK.