Bypass operation group suppression - #49039
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
ChenxiJiang333
force-pushed
the
bypass-operation-group-suppression
branch
from
September 16, 2026 09:16
8b1dadb to
61581b2
Compare
ChenxiJiang333
marked this pull request as ready for review
September 18, 2026 03:09
ChenxiJiang333
requested review from
jenny (JennyPng),
Daniel Jurek (danieljurek),
Libba Lawrence (l0lawrence) and
Laia Patiño (laiapat)
as code owners
September 18, 2026 03:09
|
Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The operation-group regression test does not invoke suppression filtering, so it passes without validating the fix.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
What changed in this PR
Updates changelog tracking to report operation-group methods and newly required model properties.
Changes:
- Bypasses
AddedClassMethodsuppression for operation groups. - Adds required-property breaking-change detection.
- Adds regression tests for both behaviors.
| File | Description |
|---|---|
breaking_changes_tracker.py |
Implements suppression bypass and required-property reporting. |
test_changelog.py |
Adds tests for the new changelog behavior. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Yuchao Yan (msyyc)
left a comment
Yuchao Yan (msyyc)
left a comment
Member
There was a problem hiding this comment.
Three correctness findings from the review.
ChenxiJiang333
force-pushed
the
bypass-operation-group-suppression
branch
from
September 22, 2026 06:49
c9c0a97 to
73ebb9e
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Property annotation extraction causes false required-property reports for equivalent nullable syntax.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Resolved since last review (1)
Yuchao Yan (msyyc)
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #48952
Include
{}.{} is now required.in the changelog for a model property is changed from optional to required