[EventHub] decode ms datetime-offset #40847
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swathipil
commented
May 1, 2025
| ticks = raw_value & TICKS_MASK # Clear the top 2 bits (kind) | ||
| kind = (raw_value >> KIND_SHIFT) & 0x3 # Extract the kind value (bits 63-64) | ||
|
|
||
| # If we have additional bytes for timezone offset (in older format) |
There was a problem hiding this comment.
TODO: see if we should replace this with check for each kind separately: https://source.dot.net/System.Private.CoreLib/R/cfa80ba62f6f6a35.html
|
API change check API changes are not detected in this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service may send back either a DateTime or DateTimeOffset. Currently, Python does not account for this.
To do so, client needs to check for the symbol b"com.microsoft:datetime-offset" and decode the value.