[AutoRelease] t2-chaos-2025-05-01-30054(can only be merged by SDK owner) #40835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Chaos Management client to a new major release, reflecting changes for API version 2025-01-01 and updates to parameter names, overloads, and type annotations. Key changes include:
- Renaming of parameters (e.g. “target” is now “resource”, “location_name” is now “location”) for consistency.
- Updated default API version and additional overloads for create/update operations.
- Refactoring to remove deprecated request conversion logic and improve type safety.
Reviewed Changes
Copilot reviewed 73 out of 74 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk/chaos/azure-mgmt-chaos/azure/mgmt/chaos/aio/operations/_targets_operations.py | Renamed parameters and refactored create/update methods. |
| sdk/chaos/azure-mgmt-chaos/azure/mgmt/chaos/aio/_configuration.py | Updated API version default and added polling_interval attribute. |
| Other files | Consistent refactoring with updated type annotations and removal of deprecated utilities. |
Files not reviewed (1)
- sdk/chaos/azure-mgmt-chaos/_meta.json: Language not supported
Comments suppressed due to low confidence (2)
sdk/chaos/azure-mgmt-chaos/azure/mgmt/chaos/aio/operations/_targets_operations.py:244
- Renaming the parameter from 'target' to 'resource' improves clarity, but this is a breaking change. Ensure that all corresponding documentation and customer integrations are updated to reflect this parameter rename.
async def create_or_update(self, resource_group_name: str, parent_provider_namespace: str, parent_resource_type: str, parent_resource_name: str, target_name: str, resource: Union[_models.Target, IO[bytes]], **kwargs: Any) -> _models.Target:
sdk/chaos/azure-mgmt-chaos/azure/mgmt/chaos/aio/operations/_targets_operations.py:115
- [nitpick] The removal of the old _convert_request call in favor of direct URL formatting looks clean, but please verify that this change does not omit any essential processing that the deprecated function provided.
_request = HttpRequest("GET", urllib.parse.urljoin(next_link, _parsed_next_link.path), params=_next_request_params)
| default value may result in unsupported behavior. | ||
| :paramtype api_version: str | ||
| """ | ||
|
|
||
| def __init__(self, credential: "AsyncTokenCredential", subscription_id: str, **kwargs: Any) -> None: | ||
| super(ChaosManagementClientConfiguration, self).__init__(**kwargs) | ||
| api_version: str = kwargs.pop("api_version", "2024-01-01") | ||
| api_version: str = kwargs.pop("api_version", "2025-01-01") |
There was a problem hiding this comment.
The default API version has been updated from '2024-01-01' to '2025-01-01'. Please update the related documentation and release notes to ensure users are informed of the new default.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Azure/sdk-release-request/issues/6129
Recording test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=3201