Skip deployment validation for local deployment when endpoint is invoked #40811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdhotems
requested review from
paulshealy1,
achauhan-scc,
kingernupur and
jayesh-tanna
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the endpoint invocation behavior to skip deployment validation for local deployments while retaining the validation for non-local cases.
- Moved deployment validation to occur after handling local endpoints
- Introduced a temporary debugging breakpoint (pdb.set_trace)
| # Until this bug is resolved https://msdata.visualstudio.com/Vienna/_workitems/edit/1446538 | ||
| if deployment_name: | ||
| self._validate_deployment_name(endpoint_name, deployment_name) | ||
| import pdb; pdb.set_trace() |
There was a problem hiding this comment.
Remove the debugging statement before merging to production to avoid unintended breakpoints in production code.
Suggested change
| import pdb; pdb.set_trace() |
Copilot uses AI. Check for mistakes.
|
API change check API changes are not detected in this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines