chore(playwrighttesting): update public classes, methods and constants as per APIView review

[Sid200026]

• Usage of ILogger provided by Microsoft.Extensions.Logging
• Usage of Extensible Enums
• Refactor class constructors
• Sync and async methods for Initialize
• Convert TestReportingClientOptions to internal class
• Renamed Os to OS

[Sid200026]

This was added as per recommendation in APIView review to use Microsoft.Extensions.Logging's ILogger interface. Added the dependency under this condition since it's used only in Extension libraries.

[azure-sdk]

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Developer.MicrosoftPlaywrightTesting.NUnit
Azure.Developer.MicrosoftPlaywrightTesting.TestLogger

[jsquire]

This should be 8.x unless there's a reason to not do so. We're in the process of bumping all of the Azure SDK dependencies to the 8.x line.

[Sid200026]

Microsoft.Extensions.Logging 8.x uses Microsoft.Bcl.AsyncInterfaces 8.x, while in Packages.Data.props, Microsoft.Bcl.AsyncInterfaces is set to 6.x -

azure-sdk-for-net/eng/Packages.Data.props

Line 104 in f97d3dd

<PackageReference Update="Microsoft.Bcl.AsyncInterfaces" Version="6.0.0" />

This causes a version mismatch in net6.0

C:\Program Files\dotnet\sdk\8.0.404\Microsoft.Common.CurrentVersion.targets(2412,5): warning MSB3277: Found conflicts b
etween different versions of "Microsoft.Bcl.AsyncInterfaces" that could not be resolved. [Dev\azure
-sdk-for-net\sdk\playwrighttesting\Azure.Developer.MicrosoftPlaywrightTesting.TestLogger\tests\Azure.Developer.Microsof
tPlaywrightTesting.TestLogger.Tests.csproj::TargetFramework=net6.0]

[jsquire]

The Async Interfaces package is in the process of being bumped to the 8.x line centrally, along with the remainder of our dependencies. Please either wait for that to complete or bump the necessary dependencies for Playwright. I'd rather not see us use an older set here that will need to be migrated separately.

A direct reference to the Async Interfaces packages locally should resolve the conflict in the interim.

[jsquire]

This causes a version mismatch in net6.0

.NET 6 reached end-of-life and is no longer a supported platform. Our test matrices are also in the process of being upgraded to remove 6 and include 9.

[Sid200026]

A direct reference to the Async Interfaces packages locally should resolve the conflict in the interim.

Do we add Microsoft.Bcl.AsyncInterfaces in the csproj with version as 8.x?

[Sid200026]

Just rechecked the dotnet build logs, the above were warnings rather than errors.

[jsquire]

Do we add Microsoft.Bcl.AsyncInterfaces in the csproj with version as 8.x?

You would add the package reference in your .csproj and add a version of 8.x in your Playwright section of the central packages file. That central version will get cleaned up when we complete the repo-wide central version bumps.

[Sid200026]

To resolve the issue with net6.0, have added the below dependencies in the central package file under the Playwright section.

    <PackageReference Update="Microsoft.Bcl.AsyncInterfaces" Version="8.0.0" />
    <PackageReference Update="System.Diagnostics.DiagnosticSource" Version="8.0.0" />

Also added reference to these packages in our base SDK's .csproj.

[ShreyaAnand]

LGTM