Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New SDK changes for Qumulo #47620

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

scorpion-ajay
Copy link
Member

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Dec 19, 2024
Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scorpion-ajay:

Your account lacks the public membership to the Microsoft GitHub organization and required of an internal contributor. Please review the Azure SDK onboarding
documentation and use the associated Teams channel for support.

You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.

Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.

Copy link
Member

@archerzz archerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of breaking changes due to deletion of auotrest.md. Need to add back those renaming changes.

URI: Uri
Etag: ETag|etag

prepend-rp-prefix:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were a lot of renaming in autorest.md. Since you've deleted it, the class names are rolled back. You need to change back using @@clientName. For details, see https://azure.github.io/typespec-azure/docs/howtos/generate-client-libraries/02client/#renaming-the-client-name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants