-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert the property policyId of type ResourceIdentifier to type String in ProtectedItem. #47618
base: main
Are you sure you want to change the base?
Convert the property policyId of type ResourceIdentifier to type String in ProtectedItem. #47618
Conversation
API change check APIView has identified API level changes in this PR and created following API reviews. |
...Azure.ResourceManager.RecoveryServicesBackup/src/Custom/Models/BackupGenericProtectedItem.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like a clarification:
in the issue, the only case of this issue is that the value is an empty string, in other cases, this property is a proper arm-id, is this the case?
If so, maybe we could try this configuration first? https://github.com/Azure/autorest.csharp/blob/a7d1bd59aeb5ab28a081ebeef06c2adb167bd983/src/AutoRest.CSharp/Common/Input/Configuration.cs#L47C67-L47C103
and if this does not work, we could add a deserialization hook to that property to make sure we do an empty string check first and then construct the ResourceIdentifier
fixed with another PR: #47626 |
Fix : #47381