Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keyvault-certificates] Migrate to TypeSpec #31875

Merged
merged 5 commits into from
Jan 17, 2025
Merged

[keyvault-certificates] Migrate to TypeSpec #31875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2666396
Migrate keyvault-certificates to TypeSpec
maorleger Nov 21, 2024
9305245
regenerate from main
maorleger Jan 17, 2025
c80fcca
changelog
maorleger Jan 17, 2025
45f6bf6
core-client min-version
maorleger Jan 17, 2025
73a2f86
re-export ActionType
maorleger Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/keyvault/keyvault-admin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
},
"sideEffects": false,
"dependencies": {
"@azure-rest/core-client": "^2.0.0",
"@azure-rest/core-client": "^2.3.2",
"@azure/abort-controller": "^2.0.0",
"@azure/core-auth": "^1.3.0",
"@azure/core-lro": "^3.1.0",
Expand Down
2 changes: 2 additions & 0 deletions sdk/keyvault/keyvault-certificates/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@

### Other Changes

- Generate code from TypeSpec. This is an internal change that should not affect customers. [#32123](https://github.com/Azure/azure-sdk-for-js/pull/32123)

## 4.9.0 (2024-10-16)

### Features Added
Expand Down
4 changes: 2 additions & 2 deletions sdk/keyvault/keyvault-certificates/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"execute:samples": "dev-tool samples run samples-dev",
"extract-api": "dev-tool run build-package && dev-tool run extract-api",
"format": "dev-tool run vendored prettier --write --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"samples-dev/*.ts\" \"test/**/*.ts\" \"samples-dev/**/*.ts\" \"*.{js,json}\"",
"generate:client": "autorest --typescript swagger/README.md",
"generate:client": "node ../generate.js",
"integration-test": "npm run integration-test:node && npm run integration-test:browser",
"integration-test:browser": "echo skipped",
"integration-test:node": "dev-tool run test:vitest --no-test-proxy --esm -- --test-timeout 350000",
Expand Down Expand Up @@ -93,9 +93,9 @@
}
},
"dependencies": {
"@azure-rest/core-client": "^2.3.2",
"@azure/abort-controller": "^2.0.0",
"@azure/core-auth": "^1.3.0",
"@azure/core-client": "^1.5.0",
"@azure/core-http-compat": "^2.0.1",
"@azure/core-lro": "^2.2.0",
"@azure/core-paging": "^1.1.1",
Expand Down
6 changes: 3 additions & 3 deletions sdk/keyvault/keyvault-certificates/review/keyvault-certificates.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@
import type { AbortSignalLike } from '@azure/abort-controller';
import { AzureLogger } from '@azure/logger';
import type { CancelOnProgress } from '@azure/core-lro';
import type * as coreClient from '@azure/core-client';
import type * as coreClient from '@azure-rest/core-client';
import type { ExtendedCommonClientOptions } from '@azure/core-http-compat';
import type { PagedAsyncIterableIterator } from '@azure/core-paging';
import { PollerLike } from '@azure/core-lro';
import type { PollOperationState } from '@azure/core-lro';
import type { TokenCredential } from '@azure/core-auth';

// @public
export type ActionType = "EmailContacts" | "AutoRenew";
// @public @deprecated
export type ActionType = CertificatePolicyAction;

// @public
export interface AdministratorContact {
Expand Down
9 changes: 8 additions & 1 deletion sdk/keyvault/keyvault-certificates/src/certificatesModels.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Licensed under the MIT License.

import type { AbortSignalLike } from "@azure/abort-controller";
import type * as coreClient from "@azure/core-client";
import type * as coreClient from "@azure-rest/core-client";
import type { ExtendedCommonClientOptions } from "@azure/core-http-compat";
import type { CancelOnProgress, PollOperationState } from "@azure/core-lro";
import type {
Expand Down Expand Up @@ -282,6 +282,13 @@ export interface LifetimeAction {
*/
export type CertificatePolicyAction = "EmailContacts" | "AutoRenew";

/**
* The action that will be executed.
* @deprecated Use {@link CertificatePolicyAction} instead.
*/
// Re-exported for backwards compatibility, at some point both ActionType and CertificatePolicyAction were exported in the public API.
export type ActionType = CertificatePolicyAction;

/**
* An interface representing a certificate's policy (without the subject properties).
*/
Expand Down
66 changes: 66 additions & 0 deletions sdk/keyvault/keyvault-certificates/src/generated/api/index.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

60 changes: 60 additions & 0 deletions sdk/keyvault/keyvault-certificates/src/generated/api/keyVaultContext.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading