-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Sync eng/common directory with azure-sdk-tools for PR 12478 #47026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Sync eng/common directory with azure-sdk-tools for PR 12478 #47026
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR synchronizes the eng/common
directory with changes from the azure-sdk-tools repository, specifically consolidating package validation functionality and improving the DevOps workflow integration.
Key Changes:
- Consolidates
Validate-Package.ps1
functionality intoValidate-All-Packages.ps1
to reduce script calls and improve efficiency - Converts script-based DevOps work item updates to function-based calls in
Prepare-Release.ps1
- Adds new helper functions and global state management for Azure DevOps authentication
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
eng/common/scripts/Validate-All-Packages.ps1 |
Major refactoring to incorporate package validation logic, add new parameters, and include multiple new functions for change log validation, API review verification, and work item management |
eng/common/scripts/Prepare-Release.ps1 |
Updates DevOps work item creation from script call to function call pattern |
eng/common/scripts/Helpers/DevOps-WorkItem-Helpers.ps1 |
Adds new helper functions for authentication, access checks, and work item updates, including global state management |
eng/common/pipelines/templates/steps/validate-all-packages.yml |
Adds new PackageInfoFiles parameter support and updates parameter definitions with proper typing |
if ($packageInfo.PSObject.Members.Name -contains "Group") { | ||
$groupId = $packageInfo.Group | ||
if ($groupId){ | ||
$fullPackageName = "${groupId}:${$packageInfo.ArtifactName}" |
Copilot
AI
Oct 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect variable expansion syntax. The $
should not be inside the braces when referencing $packageInfo.ArtifactName
. This should be ${groupId}:$($packageInfo.ArtifactName)
for proper string interpolation.
$fullPackageName = "${groupId}:${$packageInfo.ArtifactName}" | |
$fullPackageName = "${groupId}:$($packageInfo.ArtifactName)" |
Copilot uses AI. Check for mistakes.
} | ||
|
||
# Validate that we have package info files to process | ||
if (-not $ProcessedPackageInfoFiles -or $ProcessedPackageInfoFiles.Count -eq 0) { |
Copilot
AI
Oct 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The condition could be simplified to just if (-not $ProcessedPackageInfoFiles) {
since PowerShell treats empty arrays as falsy, making the count check redundant.
if (-not $ProcessedPackageInfoFiles -or $ProcessedPackageInfoFiles.Count -eq 0) { | |
if (-not $ProcessedPackageInfoFiles) { |
Copilot uses AI. Check for mistakes.
7bdc3af
to
325dcc3
Compare
325dcc3
to
b25d636
Compare
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12478 See eng/common workflow