Skip to content

Conversation

azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12478 See eng/common workflow

@azure-sdk azure-sdk requested a review from a team as a code owner October 15, 2025 23:29
@azure-sdk azure-sdk requested review from Copilot and raych1 October 15, 2025 23:29
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Oct 15, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR synchronizes the eng/common directory with changes from the azure-sdk-tools repository, specifically consolidating package validation functionality and improving the DevOps workflow integration.

Key Changes:

  • Consolidates Validate-Package.ps1 functionality into Validate-All-Packages.ps1 to reduce script calls and improve efficiency
  • Converts script-based DevOps work item updates to function-based calls in Prepare-Release.ps1
  • Adds new helper functions and global state management for Azure DevOps authentication

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
eng/common/scripts/Validate-All-Packages.ps1 Major refactoring to incorporate package validation logic, add new parameters, and include multiple new functions for change log validation, API review verification, and work item management
eng/common/scripts/Prepare-Release.ps1 Updates DevOps work item creation from script call to function call pattern
eng/common/scripts/Helpers/DevOps-WorkItem-Helpers.ps1 Adds new helper functions for authentication, access checks, and work item updates, including global state management
eng/common/pipelines/templates/steps/validate-all-packages.yml Adds new PackageInfoFiles parameter support and updates parameter definitions with proper typing

if ($packageInfo.PSObject.Members.Name -contains "Group") {
$groupId = $packageInfo.Group
if ($groupId){
$fullPackageName = "${groupId}:${$packageInfo.ArtifactName}"
Copy link

Copilot AI Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect variable expansion syntax. The $ should not be inside the braces when referencing $packageInfo.ArtifactName. This should be ${groupId}:$($packageInfo.ArtifactName) for proper string interpolation.

Suggested change
$fullPackageName = "${groupId}:${$packageInfo.ArtifactName}"
$fullPackageName = "${groupId}:$($packageInfo.ArtifactName)"

Copilot uses AI. Check for mistakes.

}

# Validate that we have package info files to process
if (-not $ProcessedPackageInfoFiles -or $ProcessedPackageInfoFiles.Count -eq 0) {
Copy link

Copilot AI Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The condition could be simplified to just if (-not $ProcessedPackageInfoFiles) { since PowerShell treats empty arrays as falsy, making the count check redundant.

Suggested change
if (-not $ProcessedPackageInfoFiles -or $ProcessedPackageInfoFiles.Count -eq 0) {
if (-not $ProcessedPackageInfoFiles) {

Copilot uses AI. Check for mistakes.

@azure-sdk azure-sdk force-pushed the sync-eng/common-users/raych1/update-validat-pkg-template-12478 branch 7 times, most recently from 7bdc3af to 325dcc3 Compare October 16, 2025 22:38
@azure-sdk azure-sdk force-pushed the sync-eng/common-users/raych1/update-validat-pkg-template-12478 branch from 325dcc3 to b25d636 Compare October 17, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants