-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add OpenRewrite recipes and samples for azure-security-keyvault-administration to automate migration to v2 #46965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you for your contribution @DoggyDoggyDoggy! We will review the pull request and get back to you soon. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
|
||
- org.openrewrite.java.ChangeMethodName: | ||
methodPattern: com.azure.security.keyvault.administration.KeyVaultBackupClientBuilder vaultUrl(..) | ||
newMethodName: endpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since KV library wanted to make it more specific and name this as vaultUrl
, we should do this customization in all KV libraries to use vaultUrl
rather than the generic endpoint
method that is generated.
cc: @vcolin7
…ertificates-pr Azure security keyvault certificates pr
…eys-pr Azure security keyvault keys pr
…ecrets-pr Azure security keyvault secrets pr
Description
This pull request provides a set of OpenRewrite recipes to automate common code transformations for the Azure App Configuration Java client.
What this PR changes
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines