Add OpenRewrite recipes and samples for azure-security-keyvault-certificates to automate migration to v2 #46941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoggyDoggyDoggy
requested review from
a team,
JonathanGiles,
jairmyree,
samvaity and
srnagar
as code owners
github-actions
bot
added
Azure SDK Tools
|
Thank you for your contribution @DoggyDoggyDoggy! We will review the pull request and get back to you soon. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
srnagar
reviewed
Oct 13, 2025
Comment on lines
+23
to
+25
| - org.openrewrite.java.ChangeMethodName: | ||
| methodPattern: com.azure.security.keyvault.certificates.CertificateClient getCertificateVersion(..) | ||
| newMethodName: getCertificate |
There was a problem hiding this comment.
We should not have this recipe. The v2 client should have getCertificateVersion method. Let's file a bug for this issue on the v2 Key Vault library.
cc: @vcolin7
Comment on lines
+27
to
+45
| # Handle purgeDeletedCertificate variants: | ||
| # - remove second arg (Context/RequestContext) if present | ||
| # - rename purgeDeletedCertificateWithResponse -> purgeDeletedCertificate | ||
|
|
||
| - org.openrewrite.java.DeleteMethodArgument: | ||
| methodPattern: com.azure.security.keyvault.certificates.CertificateClient purgeDeletedCertificateWithResponse(..) | ||
| argumentIndex: 1 | ||
|
|
||
| - org.openrewrite.java.ChangeMethodName: | ||
| methodPattern: com.azure.security.keyvault.certificates.CertificateClient purgeDeletedCertificateWithResponse(..) | ||
| newMethodName: purgeDeletedCertificate | ||
|
|
||
| - org.openrewrite.java.DeleteMethodArgument: | ||
| methodPattern: com.azure.security.keyvault.certificates.CertificateClient purgeDeletedCertificate(..) | ||
| argumentIndex: 1 | ||
|
|
||
| - org.openrewrite.java.ChangeType: | ||
| oldFullyQualifiedTypeName: com.azure.security.keyvault.certificates.CertificateClient | ||
| newFullyQualifiedTypeName: com.azure.v2.security.keyvault.certificates.CertificateClient |
There was a problem hiding this comment.
These recipes should not be needed. We should have the WithResponse methods in v2 Key Vault library too.
cc: @vcolin7
srnagar
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request provides a set of OpenRewrite recipes to automate common code transformations for the Azure App Configuration Java client.
What this PR changes
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines