[azopenaiextensions] Remove the "next page" paging which breaks when assistants are (legit… #23780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imately) deleted. This is not a problem in our code, that I can see - it's just a hazard of having a paging API where the "next token" page can be deleted.
|
/azp run go - azopenaiextensions |
|
Azure Pipelines successfully started running 1 pipeline(s). |
- Fix another area that seems a little iffy - I'm paging _after_ my assistant ID, but I'm not guaranteeing there's at least one item there.
|
/azp run go - azopenaiextensions |
|
Azure Pipelines successfully started running 1 pipeline(s). |
richardpark-msft
requested review from
jhendrixMSFT and
chlowell
as code owners
jhendrixMSFT
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a problem in our code, that I can see - it's just a hazard of having a paging API sees state from other tests that are running, so it can be removed at any time as those tests tear down.