Update vcpkg SHA to match the C++ repo #2869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 4, but sizeof(int)). See https://stackoverflow.com/questions/2172943/why-is-the-size-of-a-character-sizeofa-different-in-c-and-c Fixes error C2220: the following warning is treated as an error iot_sample_common.c(337): warning C6396: sizeof('integerConstant') always returns the size of the underlying integer type. iot_sample_common.c(354): warning C6396: sizeof('integerConstant') always returns the size of the underlying integer type.
antkmsft
requested review from
danieljurek,
weshaggard,
benbp,
ericwolz,
ewertons,
RLeclair,
vaavva,
ahsonkhan,
RickWinter,
vhvb1989,
gearama and
LarryOsterman
as code owners
weshaggard
approved these changes
Jul 12, 2024
ericwolz
approved these changes
Jul 12, 2024
RickWinter
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SHA update: Same reason as for #2808, same SHA as in Azure/azure-sdk-for-cpp#5772.
Bug fix: I had to fix the CI warning, "
warning C6396: sizeof('integerConstant') always returns the size of the underlying integer type.", and I noticed that in our code,sizeof('\0')is written with an epxectation that it will evaluate to 1. But this is one of the few things that are different between C and C++, see https://stackoverflow.com/questions/2172943/why-is-the-size-of-a-character-sizeofa-different-in-c-and-c.