Skip to content

Conversation

@magodo
Copy link
Contributor

@magodo magodo commented Dec 4, 2025

Remove the remaining directives in the readme after #38440.

This kind of issue happens from time to time. I'm surprise not see a linter to catch it.

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    Automation should then add WaitForARMFeedback label.
    ❗If you don't have permissions to remove the label, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named Swagger Avocado has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Monitor Monitor, Monitor Ingestion, Monitor Query label Dec 4, 2025
@github-actions github-actions bot added ARMReview resource-manager RPaaS WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 4, 2025
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Go sdk/resourcemanager/monitor/armmonitor
Java com.azure.resourcemanager:azure-resourcemanager-monitor-generated

@psah434
Copy link
Member

psah434 commented Dec 5, 2025

swagger avocado failing. Also why are the set of api's being removed?

@psah434 psah434 added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 5, 2025
@magodo
Copy link
Contributor Author

magodo commented Dec 10, 2025

@psah434 You can find the context in #38440. I have no idea why they are removed because I'm not from that service team. @yashmuel please provide the context, thx!

@yashmuel
Copy link
Member

yashmuel commented Dec 10, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants