Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating 2024-11-01 managedBy #31916

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Updating 2024-11-01 managedBy #31916

wants to merge 4 commits into from

Conversation

shahjoy
Copy link

@shahjoy shahjoy commented Dec 17, 2024

Updating the 2024-11-01 api-version to provide more detail about managedBy field for resource groups

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

Updating the 2024-11-01 api-version to provide more detail about managedBy field for resource groups
Copy link

openapi-pipeline-app bot commented Dec 17, 2024

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ The required check named Swagger PrettierCheck has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Copy link

openapi-pipeline-app bot commented Dec 17, 2024

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/resources/armchanges There is no API change compared with the previous version
Go sdk/resourcemanager/databoundaries/armdataboundaries There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armdeploymentscripts There is no API change compared with the previous version
.Net Azure.ResourceManager.Resources There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armdeploymentstacks There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armfeatures There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armlinks There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armlocks There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armmanagedapplications There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armpolicy There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armresources There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armsubscriptions There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armtemplatespecs There is no API change compared with the previous version
JavaScript @azure/arm-changes https://apiview.dev/Assemblies/Review/357d9a1c28c440e8a1bd4912e73149e7?revisionId=7b55915381ea48d9bbfcc55463e0aa15
JavaScript @azure/arm-databoundaries https://apiview.dev/Assemblies/Review/f3358ffd08e0441faf640392a862557f?revisionId=5b0a6c2aa5a04d8586af568635386e2a
JavaScript @azure/arm-features https://apiview.dev/Assemblies/Review/cdac4d1c1fa1462bb53e5df0b43b1fd8?revisionId=196ab955262d42d6b4280fdad42c0e64
JavaScript @azure/arm-links https://apiview.dev/Assemblies/Review/fab6f39d3aa4438bbcf44202497c232d?revisionId=168a92a88e1a4bfeb36e3f89b01fe4c7
JavaScript @azure/arm-locks https://apiview.dev/Assemblies/Review/5032ea8e14d64cd0adc264676495aba7?revisionId=d57b79bac0d44c9c9d49f4edf2140591
JavaScript @azure/arm-managedapplications https://apiview.dev/Assemblies/Review/13cbf64f04e64947ba72af718bdd91bf?revisionId=1906eb3283b94e0384d5ffab20a26e68
JavaScript @azure/arm-policy https://apiview.dev/Assemblies/Review/cda5950570364aba98f6c682240aed30?revisionId=1548bff6087c4353b893858797460fec
JavaScript @azure/arm-resources-subscriptions There is no API change compared with the previous version
JavaScript @azure/arm-resources https://apiview.dev/Assemblies/Review/2afa29187fb74b96ba17874edd55e007?revisionId=e23b2a4efc0941ae91e4abfd02f3397a
JavaScript @azure/arm-resourcesdeploymentstacks There is no API change compared with the previous version
JavaScript @azure/arm-templatespecs https://apiview.dev/Assemblies/Review/fc04625bf7df4e6e97f03f7aae3c05b7?revisionId=056787ea91244385b46f1146fd010755

@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Dec 17, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Authorization

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 17, 2024
This was referenced Dec 17, 2024
Copy link
Member

@rkmanda rkmanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Dec 19, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 19, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview removed the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-JavaScript-Sdk BreakingChange-JavaScript-Sdk-Approved brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants