Update immutable ltr ga #28735
Update immutable ltr ga #28735
Conversation
Merge main repo into fork
…k the new cmdlets to add PassThru parameter which returns LTR backup model object.
…-2024-11-01-preview
https://github.com/brandong-ms/azure-powershell into update-sql-powershell-for-rest-api-2024-11-01-preview
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for immutable Long-Term Retention (LTR) backups in Azure SQL, introducing time-based and legal hold immutability features. The implementation includes new cmdlets for managing immutability policies, updated existing cmdlets to expose immutability parameters, and comprehensive documentation.
Key Changes:
- Added four new cmdlets for managing LTR backup immutability (Lock, Remove, Set Legal Hold, Remove Legal Hold)
- Extended existing models to include immutability properties (TimeBasedImmutability, TimeBasedImmutabilityMode, LegalHoldImmutability)
- Updated Set-AzSqlDatabaseBackupLongTermRetentionPolicy to support immutability parameters
Reviewed Changes
Copilot reviewed 25 out of 64 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Sql/Sql/help/*.md | Added/updated help documentation for immutability cmdlets and properties |
| src/Sql/Sql/Properties/Resources.resx | Added user-facing warning and description strings for immutability operations |
| src/Sql/Sql/Database Backup/Services/*.cs | Implemented communicator and adapter methods for immutability API calls |
| src/Sql/Sql/Database Backup/Model/*.cs | Extended models with immutability properties |
| src/Sql/Sql/Database Backup/Cmdlet/*.cs | Implemented new cmdlets and updated existing policy cmdlet |
| src/Sql/Sql/Common/DatabaseBackupConstants.cs | Added constants for immutability values |
| src/Sql/Sql/ChangeLog.md | Documented changes for upcoming release |
| src/Sql/Sql/Az.Sql.psd1 | Exported new cmdlets |
| src/Sql/Sql.Test/SessionRecords/*.json | Added test recordings |
| src/Sql/Sql.Test/ScenarioTests/DatabaseBackupTests.cs | Added test methods for immutability features |
| src/Sql/Sql.Management.Sdk/README.md | Updated API spec references to 2024-11-01-preview |
Files not reviewed (1)
- src/Sql/Sql/Properties/Resources.Designer.cs: Language not supported
src/Sql/Sql/help/Set-AzSqlDatabaseBackupLongTermRetentionPolicy.md
Outdated
Show resolved
Hide resolved
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
…y.md Update output to reflect the command Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
There are issues detected in the examples that are unrelated to your change but got detected because of the module-level regeneration of help documents. I‘ve created #28758 . If you own those cmdlets please work on them in a separate PR.
|
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.