Fix bug in Publish-AzWebApp to allow params to be toggled off
#26167
+12
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
️✔️Az.Network
️✔️Az.Websites
|
Update ChangeLog
msJinLei
force-pushed
the
allow-params-toggle
branch
from
4c3eff0
to
89a4dae
Compare
msJinLei
added
the
Do Not Squash 🚫
msJinLei
approved these changes
Sep 25, 2024
|
|
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Publish-AzWebApppreviously did not allow the parameters to be set to false becauseParameterName.IsPresentwould resolve to false if$falsewas passed, which would bypass the if statement that set the parameter toParamName.ToString().By using IsParameterBound() we can get the desired outcome such that if
$falseis passed, we will enter the if statement and set the parameter to false. If$trueis passed, we will enter the if statement and set the parameter to true. If nothing is passed, the if statement will be skipped and the parameter will not be set, which is the corrected behavior.Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.