Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a github workflow to enforce reviews #23034

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sandido
Copy link
Member

@Sandido Sandido commented Oct 20, 2023

Description

Branched from #23033

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 20, 2023

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@Sandido Sandido marked this pull request as ready for review October 20, 2023 18:24
@github-actions
Copy link

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

@YanaXu
Copy link
Contributor

YanaXu commented Oct 30, 2023

Hi @Sandido ,
One comment is from my team: don't use an additional config file. That means only use .github/CODEOWNERS but don't add .github/enforce_review_paths.txt.
To make it work, we have to config .github/CODEOWNERS like below and let .github/workflows/script/enforce_required_reviewers_check.ps1 to handle the line # enforce=true. Please update it accordingly and test it.

# To make sure Network PRs go to the right branch, e.g. network-april
/src/Network/    @Joanna-Yang-Art @htippanaboya

# enforce=true
/src/Compute/Compute	@bilaakpan-ms @sandido @haagha @grizzlytheodore
# enforce=true
/src/Compute/Compute.AlcWrapper	@bilaakpan-ms @sandido @haagha @grizzlytheodore
# enforce=true
/src/Compute/Compute.Autorest	@bilaakpan-ms @sandido @haagha @grizzlytheodore
# enforce=true
/src/Compute/Compute.Helpers	@bilaakpan-ms @sandido @haagha @grizzlytheodore
# enforce=true
/src/Compute/Compute.Management.Sdk	@bilaakpan-ms @sandido @haagha @grizzlytheodore
# enforce=true
/src/Compute/documentation	@bilaakpan-ms @sandido @haagha @grizzlytheodore

/src/Compute/    @bilaakpan-ms @sandido @haagha @grizzlytheodore

/src/PolicyInsights/  @pilor
/src/Batch/ @wiboris @dpwatrous

# Make sure changes to .github folder go through our team's double check
/.github/        @isra-fel

@YanaXu YanaXu self-assigned this Nov 3, 2023
@wyunchi-ms
Copy link
Contributor

@YanaXu

@NoriZC
Copy link
Contributor

NoriZC commented May 29, 2024

Hi @YanaXu @Sandido Please help confirm whether this PR is active or not. If not needed, or will not be needed currenly please close it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants