certificatePath and certificateKeyPath should be read as binary #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -367,7 +367,7 @@ def install(): | |||
|
|
|||
| if "certificatePath" in protected_settings: | |||
| try: | |||
| with open(protected_settings.get("certificatePath"), 'r') as f: | |||
| with open(protected_settings.get("certificatePath"), 'rb') as f: | |||
There was a problem hiding this comment.
This code changes the read path, however the error message provided in the PR points to it attempting to write, which happens here:
There was a problem hiding this comment.
Ah, I see, it reads it and then writes it. Nevermind on this comment.
|
@williambernardet please test this on py2 and py3 both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With latest version of the agent extension, I've tried to leverage the new certificatePath and certificateKeyPath to read existing certificate, and the extension fails in the following way. As we write them back with 'wb', we need to load them as bytes.
2021/11/16 17:45:24 ERROR:Install failed with error: a bytes-like object is required, not 'str'
2021/11/16 17:45:24 ERROR:Stacktrace: Traceback (most recent call last):
2021/11/16 17:45:24 ERROR: File "./agent.py", line 189, in main
2021/11/16 17:45:24 ERROR: exit_code, output = operationsoperation
2021/11/16 17:45:24 ERROR: File "./agent.py", line 452, in install
2021/11/16 17:45:24 ERROR: fh.write(MONITORING_GCS_CERT_CERTFILE)
2021/11/16 17:45:24 ERROR:TypeError: a bytes-like object is required, not 'str'
2021/11/16 17:45:24 ERROR:
2021/11/16 17:45:24 ERROR:[Microsoft.Azure.Monitor.AzureMonitorLinuxAgent-1.14.5] Install failed with error: a bytes-lik
e object is required, not 'str'
2021/11/16 17:45:24 ERROR:Stacktrace: Traceback (most recent call last):
2021/11/16 17:45:24 ERROR: File "./agent.py", line 189, in main
2021/11/16 17:45:24 ERROR: exit_code, output = operationsoperation
2021/11/16 17:45:24 ERROR: File "./agent.py", line 452, in install
2021/11/16 17:45:24 ERROR: fh.write(MONITORING_GCS_CERT_CERTFILE)
2021/11/16 17:45:24 ERROR:TypeError: a bytes-like object is required, not 'str'
2021/11/16 17:45:24 ERROR:
2021/11/16 17:45:24 [Microsoft.Azure.Monitor.AzureMonitorLinuxAgent-1.14.5] Install,failed,1,Install failed with error:
a bytes-like object is required, not 'str'
2021/11/16 17:45:24 Stacktrace: Traceback (most recent call last):
2021/11/16 17:45:24 File "./agent.py", line 189, in main
2021/11/16 17:45:24 exit_code, output = operationsoperation
2021/11/16 17:45:24 File "./agent.py", line 452, in install
2021/11/16 17:45:24 fh.write(MONITORING_GCS_CERT_CERTFILE)
2021/11/16 17:45:24 TypeError: a bytes-like object is required, not 'str'