[pack] [EMG] fixing infinite loop issue with typeforwarders #8772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyju
reviewed
Sep 21, 2022
...ionsMetadataGenerator/src/ExtensionsMetadataGenerator.Console/ExtensionsMetadataGenerator.cs
Outdated
Show resolved
Hide resolved
kshyju
reviewed
Sep 21, 2022
...ionsMetadataGenerator/src/ExtensionsMetadataGenerator.Console/ExtensionsMetadataGenerator.cs
Show resolved
Hide resolved
jviau
approved these changes
Sep 22, 2022
...ionsMetadataGenerator/src/ExtensionsMetadataGenerator.Console/ExtensionsMetadataGenerator.cs
Show resolved
Hide resolved
...ionsMetadataGenerator/src/ExtensionsMetadataGenerator.Console/ExtensionsMetadataGenerator.cs
Outdated
Show resolved
Hide resolved
brettsam
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
fabiocav
approved these changes
Sep 22, 2022
brettsam
requested review from
madelinegordon,
kashimiz,
liliankasem,
surgupta-msft and
satvu
as code owners
satvu
approved these changes
Sep 23, 2022
liliankasem
approved these changes
Sep 23, 2022
This was referenced Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is rare, but some customers can hit an infinite loop with circular TypeForwarders. The issue in Cecil is here: jbevain/cecil#706
This fix short-circuits our search for extensions if we hit a TPA as there's no need to go further. This breaks that circular logic as we don't keep searching for base types and assemblies once we make it this far.