Add a test for PurgeAllInstancesAsync #3021
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix bug with PurgeOrchestrationHistory relating to null start date
andystaples
requested review from
cgillum,
jviau,
nytian and
bachuv
and removed request for
cgillum
bachuv
reviewed
Jan 30, 2025
| Assert.Matches(responseRegex, actualMessage); | ||
| Assert.Equal(expectedStatusCode, response.StatusCode); | ||
| } | ||
| } |
There was a problem hiding this comment.
Are there any other test cases that we can add? Maybe a test to cover the changes you made in ProtobufUtils.cs?
There was a problem hiding this comment.
This test actually does cover that case - starttime is null in the function app code for this test, and before my change, it threw instead of returning.
Would love to add more tests, though. I think a good set to start with would be
- A test with empty end date
- A test with a start and end date
- Purging from (now + 1 minute) to (now + 1 day) should delete 0 records
- Starting an orchestration, then purging from >1 day ago should not purge the new orchestration's history
- Starting an orchestration, waiting for it to complete, then purging all history should delete that orchestration's history
Does this seem reasonable? Other scenarios I should cover? @bachuv @cgillum
There was a problem hiding this comment.
That sounds good to me. For the last three bullets, I remember Chris has a sample test for reference, I also referred to this when adding purge test at DTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #2702
Pull request checklist
pending_docs.mdrelease_notes.md/src/Worker.Extensions.DurableTask/AssemblyInfo.csdevandmainbranches and will not be merged into thev2.xbranch.