.NET out-of-proc error parsing fixes #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmrdavid
approved these changes
Mar 18, 2024
Comment on lines
+661
to
+669
| // "Exception of type 'ExceptionSerialization.Function+UnknownException' was thrown." | ||
| const string startMarker = "Exception of type '"; | ||
| const string endMarker = "' was thrown."; | ||
| if (exception.StartsWith(startMarker) && exception.EndsWith(endMarker)) | ||
| { | ||
| exceptionType = exception[startMarker.Length..^endMarker.Length]; | ||
| exceptionMessage = string.Empty; | ||
| return true; | ||
| } |
There was a problem hiding this comment.
not for this PR, but I'd love to revisit this approach - something about string manipulations here makes me unsure about the robustness of our approach
There was a problem hiding this comment.
Yes, I'm uncomfortable with this too. I sent @mattchenderson a ping on Teams earlier to see if the Functions Host team might consider giving us a proper exception contract between the host and the worker in the future, which would eliminate the need for this kind of fragile string parsing.
Co-authored-by: David Justo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2711
There were a few edge cases that weren't being handled correctly when dealing with activity exceptions in .NET out-of-proc. The edge cases included:
Exception.ToString()and change the exception message formattingWorkerOptions.EnableUserCodeExceptionIn the above cases, what we receive from the .NET Isolated worker changes from what we expect, resulting in exception information missing when customers try to handle exceptions in their orchestrator function code. The changes in this PR are meant to cover these corner cases and provide users with more accurate exception information.
Pull request checklist
pending_docs.mdrelease_notes.md/src/Worker.Extensions.DurableTask/AssemblyInfo.cs