Add GitHub Actions improvements: allow actions to be triggered manually, implement (best effort) fail fast, and get MSSQL working again #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmrdavid
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates a series of GitHub Actions improvements:
(1) It adds a
workflow_dispatch:trigger for our actions, allowing them to be triggered through the UI, without needing a PR. See: https://docs.github.com/en/actions/using-workflows/manually-running-a-workflow(2) There's a known error in the
pwshGitHub Actions runners that prevents scripts from failing fast on an error. This makes debugging difficult because it's hard to find the first error on a pipeline. I added a manualExit-OnErrorstep in our scripts that exists manually whenever a step fails.(3) The MSSQL smoke tests stopped working, apparently due to the "additionalRunFlags" set of dynamic parameters. We weren't really making use of this as far as I can tell, so I removed it from the script and now it is working again.