Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CreateCheckStatusResponseAsync APIs #2718

Closed
wants to merge 1 commit into from

Conversation

jviau
Copy link
Contributor

@jviau jviau commented Jan 10, 2024

With AspNetCore support via extension in dotnet isolated, customers are unable to use our CreateCheckStatusResponse APIs due to synchronous IO not being allowed by default. While we don't want to add direct AspNetCore support at this time (would require bringing in that extension package, which is a no-go for us without our own separate package). We can in the short term add CreateCheckStatusResponseAsync which will fix the no-sync IO issue.

Issue describing the changes in this PR

resolves #2717

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation PR is ready to merge and referenced in pending_docs.md
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)
  • My changes do not require any extra work to be leveraged by OutOfProc SDKs
    • Otherwise: That work is being tracked here: #issue_or_pr_in_each_sdk
  • My changes do not change the version of the WebJobs.Extensions.DurableTask package
    • Otherwise: major or minor version updates are reflected in /src/Worker.Extensions.DurableTask/AssemblyInfo.cs
  • My changes do not add EventIds to our EventSource logs
    • Otherwise: Ensure the EventIds are within the supported range in our existing Windows infrastructure. You may validate this with a deployed app's telemetry. You may also extend the range by completing a PR such as this one.
  • My changes should be added to v3.x branch.
    • Otherwise: This change only applies to Durable Functions v2.x and will not be merged to branch v3.x.

@jviau
Copy link
Contributor Author

jviau commented Jan 10, 2024

Will update release notes before checking in (just waiting on another PR to avoid a merge conflict)

@jviau jviau closed this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant