Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MSSQL Smoke Test #2700

Merged
merged 57 commits into from
Dec 30, 2023
Merged

Add MSSQL Smoke Test #2700

merged 57 commits into from
Dec 30, 2023

Conversation

bachuv
Copy link
Collaborator

@bachuv bachuv commented Dec 20, 2023

Adds a smoke test for the MSSQL storage provider and increments the webjobs extension and worker extension reference to v2.13.1.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation PR is ready to merge and referenced in pending_docs.md
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)
  • My changes do not require any extra work to be leveraged by OutOfProc SDKs
    • Otherwise: That work is being tracked here: #issue_or_pr_in_each_sdk
  • My changes do not change the version of the WebJobs.Extensions.DurableTask package
    • Otherwise: major or minor version updates are reflected in /src/Worker.Extensions.DurableTask/AssemblyInfo.cs
  • My changes do not add EventIds to our EventSource logs
    • Otherwise: Ensure the EventIds are within the supported range in our existing Windows infrastructure. You may validate this with a deployed app's telemetry. You may also extend the range by completing a PR such as this one.
  • My changes should be added to v3.x branch.
    • Otherwise: This change only applies to Durable Functions v2.x and will not be merged to branch v3.x.

Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see this! Just a couple small things...

test/SmokeTests/BackendSmokeTests/MSSQL/MSSQL.csproj Outdated Show resolved Hide resolved
.github/workflows/smoketest-mssql-inproc-v4.yml Outdated Show resolved Hide resolved
@bachuv bachuv marked this pull request as draft December 20, 2023 18:13
@bachuv bachuv marked this pull request as ready for review December 30, 2023 00:47
@bachuv bachuv merged commit c149504 into dev Dec 30, 2023
20 checks passed
@bachuv bachuv deleted the add-mssql-smoke-test branch December 30, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants