Fix deserialization for isolated entities #2686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgillum
approved these changes
Nov 28, 2023
|
Will this fix be released anytime soon? |
|
@kweebtronic: There's a release planned sometime in the next 2 weeks approximately, so this payload come out it with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
As reported and diagnosed in #2679, custom serialization for isolated entities is not working properly because the settings in IServices are not passed as an argument when calling
LoadAndRunAsyncon theGrpcRunner.This PR fixes this problem by passing the argument.
resolves #2679
Pull request checklist
release_notes.md