Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose OOP invocation errors #2654

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Expose OOP invocation errors #2654

merged 3 commits into from
Nov 9, 2023

Conversation

jviau
Copy link
Contributor

@jviau jviau commented Nov 1, 2023 •
edited
Loading

This PR fixes an issue with failed orchestrations and entities not showing up as "failed" in telemetry.

Issue describing the changes in this PR

resolves #2595

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation PR is ready to merge and referenced in pending_docs.md
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)
  • My changes do not require any extra work to be leveraged by OutOfProc SDKs
    • Otherwise: That work is being tracked here: #issue_or_pr_in_each_sdk
  • My changes do not change the version of the WebJobs.Extensions.DurableTask package
    • Otherwise: major or minor version updates are reflected in /src/Worker.Extensions.DurableTask/AssemblyInfo.cs
  • My changes do not add EventIds to our EventSource logs
    • Otherwise: Ensure the EventIds are within the supported range in our existing Windows infrastructure. You may validate this with a deployed app's telemetry. You may also extend the range by completing a PR such as this one.
  • My changes should be added to v3.x branch.
    • Otherwise: This change only applies to Durable Functions v2.x and will not be merged to branch v3.x.

@jviau jviau mentioned this pull request Nov 3, 2023
Open
davidmrdavid
davidmrdavid reviewed Nov 8, 2023
View reviewed changes
Copy link
Contributor

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

src/WebJobs.Extensions.DurableTask/ContextImplementations/RemoteEntityContext.cs Show resolved Hide resolved
src/WebJobs.Extensions.DurableTask/ContextImplementations/RemoteEntityContext.cs Outdated Show resolved Hide resolved
davidmrdavid
davidmrdavid approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved conditional on renaming EnsureSuccess to ThrowIfFailed

@jviau jviau merged commit 391486a into dev Nov 9, 2023
19 checks passed
@jviau jviau deleted the jviau/oop-error branch November 9, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmrdavid davidmrdavid davidmrdavid approved these changes

@cgillum cgillum Awaiting requested review from cgillum

@sebastianburckhardt sebastianburckhardt Awaiting requested review from sebastianburckhardt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problems with unhandled exception in Orchestrations, .net 7 isolated mode
2 participants
@jviau @davidmrdavid