-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP APIs for .NET Isolated Parity #2653
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bachuv
commented
Nov 1, 2023
bachuv
commented
Nov 1, 2023
jviau
requested changes
Nov 1, 2023
jviau
reviewed
Nov 1, 2023
jviau
reviewed
Nov 1, 2023
jviau
reviewed
Nov 7, 2023
src/Worker.Extensions.DurableTask/DurableHttpResponseConverter.cs
Outdated
Show resolved
Hide resolved
jviau
reviewed
Nov 7, 2023
src/Worker.Extensions.DurableTask/DurableHttpResponseConverter.cs
Outdated
Show resolved
Hide resolved
jviau
requested changes
Nov 9, 2023
src/Worker.Extensions.DurableTask/TaskOrchestrationContextExtensionMethods.cs
Outdated
Show resolved
Hide resolved
jviau
requested changes
Nov 10, 2023
src/Worker.Extensions.DurableTask/TaskOrchestrationContextExtensionMethods.cs
Outdated
Show resolved
Hide resolved
src/Worker.Extensions.DurableTask/TaskOrchestrationContextExtensionMethods.cs
Outdated
Show resolved
Hide resolved
src/Worker.Extensions.DurableTask/Worker.Extensions.DurableTask.csproj
Outdated
Show resolved
Hide resolved
jviau
approved these changes
Nov 10, 2023
src/Worker.Extensions.DurableTask/TaskOrchestrationContextExtensionMethods.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds HTTP API parity (
CallHttpAsync()
) for .NET Isolated, but doesn't currently support Managed Identity authentication. Support for that feature will be added in the future.Changes include:
DurableHttpRequest
andDurableHttpResponse
types in the Worker projectTaskOrchestrationContext
extension method forCallHttpAsync()
OutOfProcMiddleware
to execute theBuiltIn::HttpActivity
activity function by using the existingTaskHttpActivityShim
(BuiltIn::HttpActivity
is the reserved name to know when a TaskActivity should be an HTTP activity).Pull request checklist
pending_docs.md
release_notes.md
/src/Worker.Extensions.DurableTask/AssemblyInfo.cs