Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP APIs for .NET Isolated Parity #2653

Merged
merged 10 commits into from
Nov 13, 2023
Merged

Conversation

bachuv
Copy link
Collaborator

@bachuv bachuv commented Nov 1, 2023

This PR adds HTTP API parity (CallHttpAsync()) for .NET Isolated, but doesn't currently support Managed Identity authentication. Support for that feature will be added in the future.
 
Changes include:

  • New DurableHttpRequest and DurableHttpResponse types in the Worker project
  • New TaskOrchestrationContext extension method for CallHttpAsync()
  • Additional changes in OutOfProcMiddleware to execute the BuiltIn::HttpActivity activity function by using the existing TaskHttpActivityShim (BuiltIn::HttpActivity is the reserved name to know when a TaskActivity should be an HTTP activity).

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation PR is ready to merge and referenced in pending_docs.md
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)
  • My changes do not require any extra work to be leveraged by OutOfProc SDKs
    • Otherwise: That work is being tracked here: #issue_or_pr_in_each_sdk
  • My changes do not change the version of the WebJobs.Extensions.DurableTask package
    • Otherwise: major or minor version updates are reflected in /src/Worker.Extensions.DurableTask/AssemblyInfo.cs
  • My changes do not add EventIds to our EventSource logs
    • Otherwise: Ensure the EventIds are within the supported range in our existing Windows infrastructure. You may validate this with a deployed app's telemetry. You may also extend the range by completing a PR such as this one.
  • My changes should be added to v3.x branch.
    • Otherwise: This change only applies to Durable Functions v2.x and will not be merged to branch v3.x.

@bachuv bachuv self-assigned this Nov 1, 2023
@bachuv bachuv marked this pull request as draft November 1, 2023 19:52
@bachuv bachuv marked this pull request as ready for review November 7, 2023 18:13
@bachuv bachuv requested a review from jviau November 7, 2023 18:24
@bachuv bachuv requested a review from jviau November 10, 2023 18:44
@bachuv bachuv requested a review from jviau November 10, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants