Apply suggestions from code review

Direct commit applicable PR suggestions Co-authored-by: Chris Gillum <[email protected]>
Azure · Jan 11, 2025 · d3f3328 · d3f3328
1 parent f171de5
commit d3f3328
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/test/e2e/Tests/Constants.cs b/test/e2e/Tests/Constants.cs
@@ -9,7 +9,7 @@ internal class Constants
     {
         public static IConfiguration Configuration = TestUtility.GetTestConfiguration();
 
-        internal static string FunctionsHostUrl = Configuration["FunctionAppUrl"] ?? "http://localhost:7071";
+        internal static readonly string FunctionsHostUrl = Configuration["FunctionAppUrl"] ?? "http://localhost:7071";
 
         internal const string FunctionAppCollectionName = "DurableTestsCollection";
     }

diff --git a/test/e2e/Tests/Fixtures/FunctionAppFixture.cs b/test/e2e/Tests/Fixtures/FunctionAppFixture.cs
@@ -82,7 +82,7 @@ public async Task InitializeAsync()
                     _jobObjectRegistry.Register(this._funcProcess);
                 }
 
-                var httpClient = new HttpClient();
+                using var httpClient = new HttpClient();
                 this._logger.LogInformation("Waiting for host to be running...");
                 await TestUtility.RetryAsync(async () =>
                 {

diff --git a/test/e2e/Tests/Helpers/HttpHelpers.cs b/test/e2e/Tests/Helpers/HttpHelpers.cs
@@ -14,7 +14,7 @@ class HttpHelpers
         public static async Task<HttpResponseMessage> InvokeHttpTrigger(string functionName, string queryString = "")
         {
             // Basic http request
-            HttpRequestMessage request = GetTestRequest(functionName, queryString);
+            using HttpRequestMessage request = GetTestRequest(functionName, queryString);
             request.Headers.Accept.Add(new MediaTypeWithQualityHeaderValue("text/plain"));
             return await GetResponseMessage(request);
         }

diff --git a/test/e2e/Tests/Tests/HelloCitiesTest.cs b/test/e2e/Tests/Tests/HelloCitiesTest.cs
@@ -22,7 +22,7 @@ public HttpEndToEndTests(FunctionAppFixture fixture, ITestOutputHelper testOutpu
         [InlineData("HelloCities_HttpStart", "", HttpStatusCode.Accepted, "")]
         public async Task HttpTriggerTests(string functionName, string queryString, HttpStatusCode expectedStatusCode, string expectedMessage)
         {
-            HttpResponseMessage response = await HttpHelpers.InvokeHttpTrigger(functionName, queryString);
+            using HttpResponseMessage response = await HttpHelpers.InvokeHttpTrigger(functionName, queryString);
             string actualMessage = await response.Content.ReadAsStringAsync();
 
             Assert.Equal(expectedStatusCode, response.StatusCode);