-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Client encryption]: Implement EncryptionContainerStream #4848
Draft
JanHyka
wants to merge
114
commits into
Azure:master
Choose a base branch
from
juraj-blazek:users/jan-hyka/new_controls
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tps://github.com/juraj-blazek/azure-cosmos-dotnet-v3 into users/juraj-blazek/encryption-benchmark-baseline
…encryption-array-pooling
…encryption-array-pooling
~ reduce validations overhead
~ update api file
… (preview) to get access to UseSystemTextJson + Stream mode support for Newtonsoft + tests and fixes
! more bugfixes on new EncryptionContainer
…rentarraybufferwriter
…an-hyka/new_controls
~ small improvements ~ cleanup
JanHyka
changed the title
[Client encryptions]: Implement EncryptionContainerStream
[Client encryption]: Implement EncryptionContainerStream
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
!This is a work in progress draft!
To allow full utilization of new EncryptionProcessor API, new EncryptionContainer was introduced. It entirely drops all premature deserializations, doesn't explicitly use Newtonsoft anywhere and works with Streams internally until the very last moment where actual strongly typed deserialization is requested. If user asks for Stream, no deserialization is performed, only decryption/decompression.
Internally RecyclableMemoryStream is used instead of MemoryStream since MemoryStream buffer resize always performs new allocation and copy.
To be processed after #4847
Includes
Type of change
Please delete options that are not relevant.
Closing issues
Constributes to #4678