OpenTelemetry Metrics: Adds support to collect Operation level metrics #4682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabh1007
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
FabianMeiswinkel and
kirillg
as code owners
sourabh1007
force-pushed
the
users/sourabhjain/otelmetriccpu
branch
from
c47f59b to
6fc4195
Compare
sourabh1007
force-pushed
the
users/sourabhjain/otelmetriccpu
branch
2 times, most recently
from
f4c3132 to
512f1ed
Compare
sourabh1007
force-pushed
the
users/sourabhjain/otelmetriccpu
branch
4 times, most recently
from
6e89d3a to
fb81cfa
Compare
sourabh1007
force-pushed
the
users/sourabhjain/otelmetriccpu
branch
from
c686b4d to
320e618
Compare
sourabh1007
force-pushed
the
users/sourabhjain/otelmetriccpu
branch
6 times, most recently
from
803f71e to
3c1be6b
Compare
sourabh1007
force-pushed
the
users/sourabhjain/otelmetriccpu
branch
from
275f5db to
ae206c9
Compare
Open
sourabh1007
force-pushed
the
users/sourabhjain/otelmetriccpu
branch
from
ae5e2c3 to
6d6957b
Compare
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/CosmosDbClientMetrics.cs
Show resolved
Hide resolved
sourabh1007
force-pushed
the
users/sourabhjain/otelmetriccpu
branch
from
6a98f46 to
a9eeba6
Compare
kirankumarkolli
approved these changes
Nov 23, 2024
microsoft-github-policy-service
bot
deleted the
users/sourabhjain/otelmetriccpu
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CosmosClientTelemetryOptionsi.e.IsClientMetricsEnabled, to enable/disable metrics. By default, it would be disabled. (inspired from Java SDK https://github.com/Azure/azure-sdk-for-java/blob/5bc07ca75c7c0520c1098b5a6264258b6e043435/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/CosmosClientTelemetryConfig.java#L61)enabled, collecting below metrics ref. Cosmos DB: Operation Level Metrics open-telemetry/semantic-conventions#1438ref. Java Metric Doumentation, https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/cosmos/azure-cosmos/docs/Metrics.md
ref. Discussion with open telemetry community open-telemetry/semantic-conventions#1438
this PR has Contract Changes.
Perf Testing
I haven't observed any performance impact from this change. In this feature, any performance issues would likely stem from the Exporter implementation or the aggregation interval. The tests were conducted using a no-op exporter subscribed to these meters to isolate any performance impact specifically related to data recording
Type of change