Conversation
a0x1ab
requested review from
YanaXu,
bebound,
jiasli,
wangzelin007 and
yonzhan
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the ParseSquadMappingList.ps1 sync script to better handle mentionees entries when auto-updating .github/policies/resourceManagement.yml, ensuring squad mentionees are normalized and de-duplicated.
Changes:
- Added a
NormalizeMentioneeValuehelper to normalize squad mentionees (e.g.,act-...-squad→Azure/act-...-squad). - Updated mentionee parsing to treat existing mentionees as present in both raw and normalized forms.
- Updated mentionee insertion to write the normalized mentionee value.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -370,8 +393,9 @@ function AddSquadLabelsToYaml { | |||
| if ($mentionItemIndent -lt 0) { $mentionItemIndent = ($mentioneesIndent -gt 0) ? $mentioneesIndent : ($listIndentLength + 4) } | |||
There was a problem hiding this comment.
The fallback for computing $mentionItemIndent treats $mentioneesIndent==0 as "unset" because it checks -gt 0. If a mentionees: block is ever at column 0 (valid YAML), this will choose ($listIndentLength + 4) and insert mis-indented mentionees, potentially breaking YAML parsing. Consider using -ge 0 (or initialize to $null and test for $null -ne $mentioneesIndent) so an indent of 0 is handled correctly.
Suggested change
| if ($mentionItemIndent -lt 0) { $mentionItemIndent = ($mentioneesIndent -gt 0) ? $mentioneesIndent : ($listIndentLength + 4) } | |
| if ($mentionItemIndent -lt 0) { $mentionItemIndent = ($mentioneesIndent -ge 0) ? $mentioneesIndent : ($listIndentLength + 4) } |
wangzelin007
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing Guide
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.