[PostgreSQL] az postgres flexible-server create, replica create, restore, geo-restore, and revive-dropped: Add breaking change announcement for command behavioral change related to network resources#33077
Conversation
…om flexible server commands
nachoalonsoportillo
requested review from
Pan-Qi,
VeryEarly,
calvinhzy and
jsntcy
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @nachoalonsoportillo, |
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
nachoalonsoportillo
requested review from
nasc17
and removed request for
Copilot
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull request overview
Adds breaking-change announcements in the PostgreSQL command module to inform users that certain az postgres flexible-server workflows will no longer create/modify customer-owned network resources, and that required networking must be provisioned via az network.
Changes:
- Updates/clarifies existing breaking-change comments for Index Tuning → Autonomous Tuning and long-term retention deprecation.
- Adds
register_other_breaking_changeannouncements for flexible-servercreate,replica create,restore, andgeo-restoreregarding network resource behavior changes. - Also adds the same announcement for
postgres flexible-server revive-dropped.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/azure-cli/azure/cli/command_modules/postgresql/_breaking_change.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/postgresql/_breaking_change.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/postgresql/_breaking_change.py
Outdated
Show resolved
Hide resolved
nachoalonsoportillo
changed the title
…ble server commands
src/azure-cli/azure/cli/command_modules/postgresql/_breaking_change.py
Outdated
Show resolved
Hide resolved
|
@calvinhzy @yonzhan please run checks and merge, we wish to have announcement in for breaking changes |
nachoalonsoportillo
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
nachoalonsoportillo
changed the title
az postgres flexible-server create, replica create, restore, geo-restore, and revive-dropped: Add breaking change announcement for command behavioral change related to network resources
|
@yonzhan Can you run checks again, please |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@calvinhzy @yonzhan please run checks and merge, we wish to have announcement in for breaking changes |
|
@nachoalonsoportillo Could you please remove or update the History section of this pull request? Since this change is intended for pre-announcement only, we don’t need to include a [Breaking Change] tag and the breaking change behavior in the history notes. |
nachoalonsoportillo
modified the milestones:
April 2026 (2026-04-07),
May 2026 (2026-05-05)
@ReaNAiveD I removed all entries from History Notes now. Is that what I was expected to do? |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| NETWORK_RESOURCE_BREAKING_CHANGE_MESSAGE = ( | ||
| 'The --address-prefixes and --subnet-prefixes arguments have been deprecated and will be removed. ' | ||
| 'This command will stop creating new network resources or altering existing ones which are required ' | ||
| 'for the server to function, such as virtual networks, subnets, IP ranges, etc. It will instead ' | ||
| 'require users to provide the necessary network resources created beforehand using the corresponding ' | ||
| 'commands from the `az network` module. This change will take effect in next breaking change ' | ||
| 'release scheduled for May 2026.' | ||
| ) |
There was a problem hiding this comment.
The text states '--address-prefixes' and '--subnet-prefixes' 'have been deprecated', but this diff only registers register_other_breaking_change(...) and does not register argument deprecations for those options. Either (a) update the message to say the arguments 'will be deprecated' (announcement-only), or (b) also call register_argument_deprecate(...) for these arguments on the affected commands so users get deprecation warnings consistent with the announcement.
| 'commands from the `az network` module. This change will take effect in next breaking change ' | ||
| 'release scheduled for May 2026.' |
There was a problem hiding this comment.
Minor grammar: 'take effect in next breaking change release' should be 'take effect in the next breaking change release'.
Related command
az postgres flexible-server createaz postgres flexible-server replica createaz postgres flexible-server restoreaz postgres flexible-server geo-restoreaz postgres flexible-server revive-droppedDescription
Creation or modification of customer owned network resources currently implemented in this module will be removed.
Required network resources for the server to function should be provisioned or altered using the commands provided by the
az networkmodule.Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.