Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
jiasli
requested review from
bebound,
teresaritorto and
yonzhan
and removed request for
Copilot
| /src/azure-cli-core/azure/cli/core/style.py @NoriZC @yanzhudd @teresaritorto | ||
| /src/azure-cli-core/azure/cli/core/aaz/ @VeryEarly @Pan-Qi @jsntcy @necusjz | ||
|
|
||
| /src/azure-cli/ @necusjz @DanielMicrosoft @ReaNAiveD @yonzhan @bebound @jiasli |
There was a problem hiding this comment.
This is mainly for
src/azure-cli/setup.pysrc/azure-cli/requirements.py3.Darwin.txtsrc/azure-cli/requirements.py3.Linux.txtsrc/azure-cli/requirements.py3.windows.txt
There was a problem hiding this comment.
Pull request overview
Updates repository CODEOWNERS to adjust/restore ownership coverage for key areas (notably top-level tooling/scripts and the src/ packages) to ensure the right reviewers can approve changes to packaging/dependency-related files.
Changes:
- Add additional code owners to
/linter_exclusions.yml,/tools/,/scripts/, and/scripts/live_test. - Expand ownership for
/src/azure-cli-testsdk/and/src/azure-cli-core/. - Add a new ownership rule for
/src/azure-cli/and update/src/azure-cli/.../util/.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /src/azure-cli-core/azure/cli/core/style.py @NoriZC @yanzhudd @teresaritorto | ||
| /src/azure-cli-core/azure/cli/core/aaz/ @VeryEarly @Pan-Qi @jsntcy @necusjz | ||
|
|
||
| /src/azure-cli/ @necusjz @DanielMicrosoft @ReaNAiveD @yonzhan @bebound @jiasli |
There was a problem hiding this comment.
The PR description calls out src/azure-cli-telemetry/setup.py, but there is no CODEOWNERS rule for /src/azure-cli-telemetry/ (or that specific setup.py). As-is, changes under src/azure-cli-telemetry/ will still not get the intended ownership/review requirements. Consider adding a /src/azure-cli-telemetry/ ... entry (or update the PR description if telemetry is intentionally out of scope).
| /scripts/live_test @naganandyala @bebound @YanaXu @yonzhan @wangzelin007 | ||
| /src/azure-cli-testsdk/ @necusjz @DanielMicrosoft @ReaNAiveD @yonzhan | ||
| /scripts/ @naganandyala @YanaXu @yonzhan @wangzelin007 @bebound @jiasli | ||
| /scripts/live_test @naganandyala @YanaXu @yonzhan @wangzelin007 @bebound @jiasli |
There was a problem hiding this comment.
/scripts/live_test is a directory, but this CODEOWNERS pattern is missing a trailing /. Elsewhere in this file directory patterns are written with a trailing slash (e.g., /scripts/, /tools/, /doc/), which also avoids accidentally matching a file named live_test. Consider changing this to /scripts/live_test/ for consistency and clarity.
| /scripts/live_test @naganandyala @YanaXu @yonzhan @wangzelin007 @bebound @jiasli | |
| /scripts/live_test/ @naganandyala @YanaXu @yonzhan @wangzelin007 @bebound @jiasli |
Description
Revert some of the changes of #32956. Permissions are needed for updating following files:
/src/azure-cli/setup.py/src/azure-cli-core/setup.py/src/azure-cli-telemetry/setup.py/src/azure-cli-testsdk/setup.py/src/azure-cli/requirements.py3.Darwin.txt/src/azure-cli/requirements.py3.Linux.txt/src/azure-cli/requirements.py3.windows.txtFor example, these files are updated in #32859