{Compute} az vm/vmss create: Set file mode when generating Ed25519 SSH keys
#30077
+1,247
−1,263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanzhudd
requested review from
zhoxing-ms,
jsntcy and
wangzelin007
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Compute |
microsoft-github-policy-service
bot
added
the
Compute
|
Hi @jiasli, could you please review this PR? |
…erate-ssh-keys-ed25519
jiasli
reviewed
Oct 17, 2024
| s = public_key.public_bytes( | ||
| encoding=serialization.Encoding.OpenSSH, | ||
| format=serialization.PublicFormat.OpenSSH) | ||
| public_key = s.decode(encoding="utf8").replace("\n", "") |
There was a problem hiding this comment.
public_bytes contains bytes which can be directly written to a file opened as wb, eliminating the necessity to decode it to a str.
jiasli
reviewed
Oct 17, 2024
| s = public_key.public_bytes( | ||
| encoding=serialization.Encoding.OpenSSH, | ||
| format=serialization.PublicFormat.OpenSSH) | ||
| public_key = s.decode(encoding="utf8").replace("\n", "") |
There was a problem hiding this comment.
Please confirm if removing \n is necessary.
jiasli
reviewed
Oct 17, 2024
There was a problem hiding this comment.
It is not needed to re-record this file if the HTTP requests don't change.
There was a problem hiding this comment.
In fact, I re-record this file just to make sure the change won't bring any unexpected results.
I'll exclude it from the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az vm/vmss createDescription
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.