-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{doc} Add security guidance for az
cmd execution
#30069
Open
AllyW
wants to merge
5
commits into
Azure:dev
Choose a base branch
from
AllyW:add-az-cmd-doc
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
doc |
AllyW
changed the title
{doc} Add security guidance for
{doc} Add security guidance for Oct 11, 2024
az
cmdaz
cmd execution
3 tasks
jiasli
reviewed
Oct 12, 2024
jiasli
reviewed
Oct 12, 2024
jiasli
reviewed
Oct 12, 2024
jiasli
reviewed
Oct 12, 2024
|
||
# code after: | ||
from .aaz.latest.monitor.autoscale import Show as AutoScaleShow | ||
autoscale_settings = AutoScaleShow(cli_ctx=instance.cli_ctx)(command_args={ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
command_args
is a positional arugment:
azure-cli/src/azure-cli/azure/cli/command_modules/monitor/aaz/latest/monitor/autoscale/_show.py
Line 31 in e92a604
def _handler(self, command_args): |
It is not the convention to call it as keyword arguments as command_args=
.
Co-authored-by: Jiashuo Li <[email protected]>
Co-authored-by: Jiashuo Li <[email protected]>
Co-authored-by: Jiashuo Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
This pr is a full guidance doc for executing az-related cmds in cli, including
run_az_cmd
(#29899)Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a
: Make some customer-facing breaking change[Component Name 2]
az command b
: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.