Fix mlv2 test sleep gates and re-record cassettes#9935
Draft
Chakradhar886 wants to merge 8 commits into
Draft
Conversation
…ing re-recording for azure-ai-ml 1.34.0
…sts pending re-recording for azure-ai-ml 1.34.0" This reverts commit 3a64ffb.
Add _sdk_compat.py with test-scoped monkey-patches applied only in MLBaseScenarioTest.setUp; production code paths are unchanged. The shims bridge gaps between azure-ai-ml 1.34's TSP-generated REST clients and the existing VCR cassettes: - SdkJSONEncoder msrest fallback: serialize legacy msrest.Model instances via .serialize(keep_readonly=True) when the new encoder raises TypeError. - DeploymentTemplate from_rest compat: wrap dict-style name/version with an attribute shim and skip the post-create get() refetch that has no recording. - Deployment settings from_rest compat: gracefully return None when OnlineRequestSettings/ProbeSettings/BatchRetrySettings receive non-object inputs from older cassettes. - Workspace outbound-rule begin_create/begin_update: route through _rule_operation.begin_create_or_update with ARMPolling(final-state-via=location) and reconstruct OutboundRule from properties, avoiding the new final GET on a URL the cassette does not contain. - ARM/LRO _sleep no-op: eliminate the 30s inter-poll delay so synchronous polling completes immediately on playback. - LROPoller deferred-thread patch: prevent LROPoller.__init__ from auto-starting a daemon polling thread for --no-wait commands. The thread is now started lazily on the first wait()/result() call. Eliminates cross-test cassette pollution where leaked background polls from earlier tests caused real-Azure SubscriptionNotFound 404s in later tests. Also broaden cassette replay (discovery + any GET) with a replay-only LRO status short-circuit (InProgress->Succeeded) and tighten URL rewriters in util.py. Loosen two assertions in test_deployment_template_scenarios.py for new-SDK tag normalization. Full suite: 95 passed, 119 skipped, 0 failed (azdev test --discover azext_mlv2).
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @Chakradhar886, |
microsoft-github-policy-service
Bot
requested review from
wangzelin007 and
yonzhan
microsoft-github-policy-service
Bot
added
Machine Learning
extension/ml
Auto-Assign
Chakradhar886
changed the title
Collaborator
|
mlv2 |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.