Skip to content

Update to v1.0.0b5 with SKR policy and critical bug fixes#9740

Open
sakshamgargMS wants to merge 3 commits intoAzure:mainfrom
sakshamgargMS:feature/managedcleanroom-v1.0.0b5-skr-policy-bugfixes
Open

Update to v1.0.0b5 with SKR policy and critical bug fixes#9740
sakshamgargMS wants to merge 3 commits intoAzure:mainfrom
sakshamgargMS:feature/managedcleanroom-v1.0.0b5-skr-policy-bugfixes

Conversation

@sakshamgargMS
Copy link
Copy Markdown
Contributor

@sakshamgargMS sakshamgargMS commented Mar 29, 2026 •
edited
Loading

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Mar 29, 2026 •
edited
Loading

❌Azure CLI Extensions Breaking Change Test
❌managedcleanroom
rule cmd_name rule_message suggest_message
❌ 1002 - CmdRemove managedcleanroom frontend analytics cleanroompolicy cmd managedcleanroom frontend analytics cleanroompolicy removed please confirm cmd managedcleanroom frontend analytics cleanroompolicy removed
⚠️ 1001 - CmdAdd managedcleanroom frontend analytics skr-policy cmd managedcleanroom frontend analytics skr-policy added

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Mar 29, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 29, 2026

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Mar 29, 2026
@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

microsoft-github-policy-service bot commented Mar 29, 2026

Thank you for your contribution @sakshamgargMS! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 29, 2026

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 29, 2026

@yonzhan yonzhan requested a review from necusjz March 29, 2026 23:45
@necusjz
Copy link
Copy Markdown
Member

necusjz commented Mar 30, 2026

@sakshamgargMS please fix the ci failures.

Saksham Garg added 2 commits March 30, 2026 11:38
Add breaking change registration for deprecated cleanroompolicy command
5154b9b 
- Register cleanroompolicy command as deprecated with redirect to skr-policy
- This acknowledges the breaking change introduced in v1.0.0b5
- Required for Azure CLI Extensions CI breaking change test
Fix test mocks to accept encoding parameter for Python 3.10-3.12 comp…
e6a50d7 
…atibility

- Updated mock_open_handler in test_publish_query_with_parameters_from_files to accept **kwargs
- Added proper file mock for test_publish_query_disallows_mixed_segments
- Fixed assertion text to match actual error message
- All 54 tests now passing on Python 3.10, 3.11, 3.12, and 3.13
@sakshamgargMS
Copy link
Copy Markdown
Contributor Author

sakshamgargMS commented Mar 30, 2026

Addressed CI failures @necusjz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@necusjz necusjz Awaiting requested review from necusjz

At least 1 approving review is required to merge this pull request.

Assignees

@necusjz necusjz

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Milestone

April 2026 (2026-04-07)

Development

Successfully merging this pull request may close these issues.

3 participants

@sakshamgargMS @yonzhan @necusjz