Skip to content

[aks-preview] Skip rollback auto-upgrade warning when only nodeOSUpgradeChannel is active for orchestrator-only rollback #9733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
InduSridhar wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

[aks-preview] Skip rollback auto-upgrade warning when only nodeOSUpgradeChannel is active for orchestrator-only rollback #9733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/aks-preview/azext_aks_preview/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2298,14 +2298,22 @@ def aks_agentpool_rollback(cmd, # pylint: disable=unused-argument
"unmanaged",
]

if upgrade_channel_enabled or node_os_channel_enabled:
if upgrade_channel_enabled:
logger.warning(
"Auto-upgrade is enabled on cluster '%s' (upgradeChannel=%s, nodeOSUpgradeChannel=%s). "
"Rollback will not succeed until auto-upgrade is disabled. Please disable auto-upgrade to roll back the node pool.",
cluster_name,
upgrade_channel or "none",
node_os_upgrade_channel or "Unmanaged",
)
if node_os_channel_enabled:
logger.warning(
"nodeOSUpgradeChannel is enabled on cluster '%s' (nodeOSUpgradeChannel=%s). "
"The orchestrator version rollback will proceed, but the node image rollback "
"will not succeed. Please disable nodeOSUpgradeChannel if you want to roll back the node image.",
cluster_name,
node_os_upgrade_channel,
)
except Exception as ex: # pylint: disable=broad-except
logger.debug("Unable to retrieve auto-upgrade configuration before rollback: %s", ex)

Expand Down
Loading