Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update domain after Microsoft Docs rebranding to Microsoft Learn #8179

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xmdanni
Copy link

@xmdanni xmdanni commented Oct 22, 2024

Microsoft Docs has been rebranded to Microsoft Learn for a long time, outdated links can have a negative impact on the output of the generative AI for Knowledge Service. So, links on reference pages need to use our new domain.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Oct 22, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @xmdanni,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 22, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Oct 22, 2024

Hi @xmdanni

Release Suggestions

Module: aks-preview

  • Please log updates into to src/aks-preview/HISTORY.rst
  • Update VERSION to 13.0.0b2 in src/aks-preview/setup.py

Module: alertsmanagement

  • Update VERSION to 1.0.0b2 in src/alertsmanagement/setup.py

Module: aosm

  • Please log updates into to src/aosm/HISTORY.rst
  • Update VERSION to 2.0.0b2 in src/aosm/setup.py

Module: appservice-kube

  • Please log updates into to src/appservice-kube/HISTORY.rst
  • Update VERSION to 1.0.0b1 in src/appservice-kube/setup.py

Module: automation

  • Please log updates into to src/automation/HISTORY.rst
  • Update VERSION to 1.0.0b2 in src/automation/setup.py
  • Set azext.isPreview to true in azext_metadata.json for automation
  • Remove azext.isExperimental: true in azext_automation/azext_metadata.json

Module: azure-firewall

  • Please log updates into to src/azure-firewall/HISTORY.rst
  • Update VERSION to 1.2.2 in src/azure-firewall/setup.py

Module: azurelargeinstance

  • Please log updates into to src/azurelargeinstance/HISTORY.rst
  • Update VERSION to 1.0.0b5 in src/azurelargeinstance/setup.py

Module: blueprint

  • Please log updates into to src/blueprint/HISTORY.rst
  • Update VERSION to 1.0.0b1 in src/blueprint/setup.py
  • Set azext.isPreview to true in azext_metadata.json for blueprint
  • Remove azext.isExperimental: true in azext_blueprint/azext_metadata.json

Module: confcom

  • Please log updates into to src/confcom/HISTORY.rst
  • Update VERSION to 1.1.2 in src/confcom/setup.py

Module: connectedk8s

  • Please log updates into to src/connectedk8s/HISTORY.rst
  • Update VERSION to 1.10.3 in src/connectedk8s/setup.py

Module: containerapp

  • Please log updates into to src/containerapp/HISTORY.rst
  • Update VERSION to 1.0.0b5 in src/containerapp/setup.py

Module: cosmosdb-preview

  • Please log updates into to src/cosmosdb-preview/HISTORY.rst
  • Update VERSION to 1.1.0b2 in src/cosmosdb-preview/setup.py

Module: costmanagement

  • Please log updates into to src/costmanagement/HISTORY.rst
  • Update VERSION to 1.0.1 in src/costmanagement/setup.py

Module: databricks

  • Please log updates into to src/databricks/HISTORY.rst
  • Update VERSION to 1.0.2 in src/databricks/setup.py

Module: datafactory

  • Please log updates into to src/datafactory/HISTORY.rst
  • Update VERSION to 1.0.3 in src/datafactory/setup.py

Module: dataprotection

  • Please log updates into to src/dataprotection/HISTORY.rst
  • Update VERSION to 1.5.6 in src/dataprotection/setup.py

Module: desktopvirtualization

  • Please log updates into to src/desktopvirtualization/HISTORY.rst
  • Update VERSION to 1.0.1 in src/desktopvirtualization/setup.py

Module: dms-preview

  • Please log updates into to src/dms-preview/HISTORY.rst
  • Update VERSION to 1.0.0b1 in src/dms-preview/setup.py

Module: fluid-relay

  • Please log updates into to src/fluid-relay/HISTORY.rst
  • Update VERSION to 1.0.0 in src/fluid-relay/setup.py

Module: front-door

  • Please log updates into to src/front-door/HISTORY.rst
  • Update VERSION to 1.2.1 in src/front-door/setup.py

Module: hardware-security-modules

  • Please log updates into to src/hardware-security-modules/HISTORY.rst
  • Update VERSION to 1.0.0b1 in src/hardware-security-modules/setup.py
  • Set azext.isPreview to true in azext_metadata.json for hardware-security-modules
  • Remove azext.isExperimental: true in azext_hardware-security-modules/azext_metadata.json

Module: hdinsightonaks

  • Please log updates into to src/hdinsightonaks/HISTORY.rst
  • Update VERSION to 1.0.0b4 in src/hdinsightonaks/setup.py

Module: hpc-cache

  • Please log updates into to src/hpc-cache/HISTORY.rst
  • Update VERSION to 1.0.0 in src/hpc-cache/setup.py

Module: image-gallery

  • Please log updates into to src/image-gallery/HISTORY.rst
  • Update VERSION to 1.0.0 in src/image-gallery/setup.py

Module: import-export

  • Please log updates into to src/import-export/HISTORY.rst
  • Update VERSION to 1.0.0b2 in src/import-export/setup.py

Module: init

  • Please log updates into to src/init/HISTORY.rst
  • Update VERSION to 1.0.0b1 in src/init/setup.py

Module: k8s-configuration

  • Please log updates into to src/k8s-configuration/HISTORY.rst
  • Update VERSION to 2.1.1 in src/k8s-configuration/setup.py

Module: k8s-extension

  • Please log updates into to src/k8s-extension/HISTORY.rst
  • Update VERSION to 1.6.3 in src/k8s-extension/setup.py

Module: load

  • Please log updates into to src/load/HISTORY.rst
  • Update VERSION to 1.2.1 in src/load/setup.py

Module: log-analytics-solution

  • Please log updates into to src/log-analytics-solution/HISTORY.rst
  • Update VERSION to 1.0.2 in src/log-analytics-solution/setup.py

Module: logic

  • Please log updates into to src/logic/HISTORY.rst
  • Update VERSION to 1.1.1 in src/logic/setup.py

Module: mesh

  • Please log updates into to src/mesh/HISTORY.rst
  • Update VERSION to 1.0.0b2 in src/mesh/setup.py

Module: notification-hub

  • Please log updates into to src/notification-hub/HISTORY.rst
  • Update VERSION to 1.0.0b2 in src/notification-hub/setup.py
  • Set azext.isPreview to true in azext_metadata.json for notification-hub

Module: offazure

  • Please log updates into to src/offazure/HISTORY.rst
  • Update VERSION to 1.0.0b1 in src/offazure/setup.py
  • Set azext.isPreview to true in azext_metadata.json for offazure
  • Remove azext.isExperimental: true in azext_offazure/azext_metadata.json

Module: portal

  • Please log updates into to src/portal/HISTORY.rst
  • Update VERSION to 1.0.0b1 in src/portal/setup.py
  • Set azext.isPreview to true in azext_metadata.json for portal
  • Remove azext.isExperimental: true in azext_portal/azext_metadata.json

Module: quantum

  • Update VERSION to 1.0.0b5 in src/quantum/setup.py

Module: quota

  • Please log updates into to src/quota/HISTORY.rst
  • Update VERSION to 1.0.1 in src/quota/setup.py

Module: resource-mover

  • Please log updates into to src/resource-mover/HISTORY.rst
  • Update VERSION to 1.0.0 in src/resource-mover/setup.py

Module: serviceconnector-passwordless

  • Please log updates into to src/serviceconnector-passwordless/HISTORY.rst
  • Update VERSION to 3.1.4 in src/serviceconnector-passwordless/setup.py

Module: spring

  • Please log updates into to src/spring/HISTORY.rst
  • Update VERSION to 1.26.1 in src/spring/setup.py

Module: spring-cloud

  • Please log updates into to src/spring-cloud/HISTORY.rst
  • Update VERSION to 3.1.9 in src/spring-cloud/setup.py

Module: ssh

  • Please log updates into to src/ssh/HISTORY.rst
  • Update VERSION to 2.0.7 in src/ssh/setup.py

Module: storage-blob-preview

  • Please log updates into to src/storage-blob-preview/HISTORY.rst
  • Update VERSION to 1.0.0b2 in src/storage-blob-preview/setup.py

Module: storage-preview

  • Please log updates into to src/storage-preview/HISTORY.rst
  • Update VERSION to 1.0.0b5 in src/storage-preview/setup.py

Module: storagesync

  • Please log updates into to src/storagesync/HISTORY.rst
  • Update VERSION to 1.0.2 in src/storagesync/setup.py

Module: stream-analytics

  • Please log updates into to src/stream-analytics/HISTORY.rst
  • Update VERSION to 1.0.1 in src/stream-analytics/setup.py

Module: virtual-network-tap

  • Please log updates into to src/virtual-network-tap/HISTORY.rst
  • Update VERSION to 1.0.0b3 in src/virtual-network-tap/setup.py

Module: virtual-wan

  • Please log updates into to src/virtual-wan/HISTORY.rst
  • Update VERSION to 1.0.2 in src/virtual-wan/setup.py

Module: vm-repair

  • Please log updates into to src/vm-repair/HISTORY.rst
  • Update VERSION to 2.0.1 in src/vm-repair/setup.py

Module: vmware

  • Please log updates into to src/vmware/HISTORY.rst
  • Update VERSION to 7.1.1 in src/vmware/setup.py

Module: workloads

  • Please log updates into to src/workloads/HISTORY.rst
  • Update VERSION to 1.1.0b4 in src/workloads/setup.py

Notes

@@ -1032,7 +1032,7 @@ async def get_available_agent_pool_versions(
"""Gets a list of supported Kubernetes versions for the specified agent pool.

See `supported Kubernetes versions
<https://docs.microsoft.com/azure/aks/supported-kubernetes-versions>`_ for more details about
<https://learn.microsoft.com/azure/aks/supported-kubernetes-versions>`_ for more details about
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content under path vendored_sdks is generated based on swagger. I think you'll need to change the content of source, otherwise these changes will be overwritten when the new SDK is generated.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Where is the source content?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants